All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, "Rafał Miłecki" <zajec5@gmail.com>
Subject: Re: [PATCH] mtd: parsers: bcm47xxpart: Fix halfblock reads
Date: Tue, 18 Oct 2022 10:15:45 +0200	[thread overview]
Message-ID: <20221018101545.14096421@xps-13> (raw)
In-Reply-To: <85d81d4d-cdc5-2cd6-3cfd-5cf8e15d6a10@gmail.com>

Hi Florian, Linus,

f.fainelli@gmail.com wrote on Mon, 17 Oct 2022 15:18:15 -0700:

> On 10/13/22 15:28, Linus Walleij wrote:
> > There is some code in the parser that tries to read 0x8000
> > bytes into a block to "read in the middle" of the block. Well
> > that only works if the block is also 0x10000 bytes all the time,
> > else we get these parse errors as we reach the end of the flash:
> > 
> > spi-nor spi0.0: mx25l1606e (2048 Kbytes)
> > mtd_read error while parsing (offset: 0x200000): -22  
> 
> Is it worth a Fixes: tag so it reaches stable eventually and we have this reach OpenWrt directly where it is presumably the most useful?

Agreed. Linus, can you resend with Fixes: tag? I'll apply it right away
to mtd/fixes.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

      reply	other threads:[~2022-10-18  8:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-13 22:28 [PATCH] mtd: parsers: bcm47xxpart: Fix halfblock reads Linus Walleij
2022-10-17 22:18 ` Florian Fainelli
2022-10-18  8:15   ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221018101545.14096421@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.