From: Christoph Hellwig <hch@lst.de>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: hch@lst.de, Keith Busch <kbusch@kernel.org>,
Daniel Wagner <dwagner@suse.de>,
Alan Adamson <alan.adamson@oracle.com>,
gost.dev@samsung.com, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: ignore starting sector while error logging for passthrough requests
Date: Tue, 18 Oct 2022 16:45:35 +0200 [thread overview]
Message-ID: <20221018144535.GA20131@lst.de> (raw)
In-Reply-To: <3f6f41b5-c743-83f7-a8f4-ab3ee2f16b3a@samsung.com>
On Tue, Oct 18, 2022 at 03:48:57PM +0200, Pankaj Raghav wrote:
> The final consensus in Daniel's patch[1] seems to be adding an opt in to
> log error only for admin commands, and logging error for user IO commands
> will remain as is.
Hmm, is it? I'd think even for I/O commands the opt in makes some
sense.
> In that case, should we reconsider this patch to avoid printing a garbage
> value ((sector_t)-1) while logging error for IO passthrough commands?
We should probably do this, but it should probably go along with the
opt-in for I/O commands.
next prev parent reply other threads:[~2022-10-18 14:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221006091054eucas1p1e4113b6dfd108907c2cd5ba7127a3f92@eucas1p1.samsung.com>
2022-10-06 9:10 ` [PATCH] nvme: ignore starting sector while error logging for passthrough requests Pankaj Raghav
2022-10-18 13:48 ` Pankaj Raghav
2022-10-18 14:45 ` Christoph Hellwig [this message]
2022-10-18 15:23 ` Keith Busch
2022-10-18 15:26 ` Christoph Hellwig
2022-10-18 16:35 ` Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018144535.GA20131@lst.de \
--to=hch@lst.de \
--cc=alan.adamson@oracle.com \
--cc=dwagner@suse.de \
--cc=gost.dev@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.