All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andreas Oetken <ennoerlangen@gmail.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org,
	Richard Weinberger <richard@nod.at>,
	Tokunori Ikegami <ikegami.t@gmail.com>,
	Andreas Oetken <andreas.oetken@siemens-energy.com>
Subject: Re: [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC
Date: Wed, 19 Oct 2022 21:34:52 +0200	[thread overview]
Message-ID: <20221019213452.18fc681e@xps-13> (raw)
In-Reply-To: <Y1Aeq5Jzj7+RdCSd@kroah.com>

Hi Andreas,

gregkh@linuxfoundation.org wrote on Wed, 19 Oct 2022 17:58:35 +0200:

> On Wed, Oct 19, 2022 at 05:49:24PM +0200, Andreas Oetken wrote:
> > Apply existing fixups to MT28FW02GBBA1HPC from:
> > Commit 0a8e98305f63deaf0a799d5cf5532cc83af035d1 ("mtd: cfi_cmdset_0002:
> > Use chip_ready() for write on S29GL064N")
> > Commit 0fe3ede7941dfcd6fd540fc2b086453d3ee8f236 ("mtd: cfi: Add early
> > fixup for S70GL02GS")  
> 
> That's not the proper way to reference commits in changelog texts.  No
> need to use the full sha1.  See the documentation for more details.
> 
> Also, this text means nothing.  Please spell out what you are doing and
> why you are doing it.  as-is it doesn't really make any sense.

Indeed. And the title prefix is still wrong :)
git log --oneline -- drivers/mtd/chips/cfi_cmdset* should help.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-10-19 19:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-19 15:49 [PATCH] mtd: cfi: add fixups to support MT28FW02GBBA1HPC Andreas Oetken
2022-10-19 15:58 ` Greg Kroah-Hartman
2022-10-19 19:34   ` Miquel Raynal [this message]
2022-10-19 16:18 ` Tokunori Ikegami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019213452.18fc681e@xps-13 \
    --to=miquel.raynal@bootlin.com \
    --cc=andreas.oetken@siemens-energy.com \
    --cc=ennoerlangen@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ikegami.t@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.