Re: [PATCH mptcp-next v14 6/7] selftests/bpf: Add bpf_red scheduler

[Geliang Tang <geliang.tang@suse.com>]

On Wed, Oct 19, 2022 at 09:36:04PM +0800, Geliang Tang wrote:
> This patch implements the redundant BPF MPTCP scheduler, named bpf_red,
> which sends all packets redundantly on all available subflows.
> 
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>  .../selftests/bpf/progs/mptcp_bpf_red.c       | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_red.c
> 
> diff --git a/tools/testing/selftests/bpf/progs/mptcp_bpf_red.c b/tools/testing/selftests/bpf/progs/mptcp_bpf_red.c
> new file mode 100644
> index 000000000000..f8a9b4d1630d
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/mptcp_bpf_red.c
> @@ -0,0 +1,37 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2022, SUSE. */
> +
> +#include <linux/bpf.h>
> +#include "bpf_tcp_helpers.h"
> +
> +char _license[] SEC("license") = "GPL";
> +
> +SEC("struct_ops/mptcp_sched_red_init")
> +void BPF_PROG(mptcp_sched_red_init, const struct mptcp_sock *msk)
> +{
> +}
> +
> +SEC("struct_ops/mptcp_sched_red_release")
> +void BPF_PROG(mptcp_sched_red_release, const struct mptcp_sock *msk)
> +{
> +}
> +
> +void BPF_STRUCT_OPS(bpf_red_get_subflow, const struct mptcp_sock *msk,
> +		   struct mptcp_sched_data *data)
> +{
> +	for (int i = 0; i < MPTCP_SUBFLOWS_MAX; i++) {
> +		if (!data->contexts[i])
> +			break;
> +
> +		mptcp_subflow_set_scheduled(data->contexts[i], true);
> +	}
> +}
> +
> +SEC(".struct_ops")
> +struct mptcp_sched_ops red = {
> +	.init		= (void *)mptcp_sched_red_init,
> +	.release	= (void *)mptcp_sched_red_release,
> +	.data_init	= (void *)bpf_red_data_init,

This line should be dropped. Will update in v15.

-Geliang

> +	.get_subflow	= (void *)bpf_red_get_subflow,
> +	.name		= "bpf_red",
> +};
> -- 
> 2.35.3
>