From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Wolfram Sang <wsa-dev@sang-engineering.com>
Cc: Jason Gerecke <killertofu@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
LKML <linux-kernel@vger.kernel.org>,
Ping Cheng <pinglinux@gmail.com>,
"Tobita, Tatsunosuke" <tatsunosuke.tobita@wacom.com>,
Jason Gerecke <jason.gerecke@wacom.com>,
Ping Cheng <ping.cheng@wacom.com>
Subject: Re: [PATCH v2] i2c: Use u8 type in i2c transfer calls
Date: Thu, 20 Oct 2022 11:35:41 +0100 [thread overview]
Message-ID: <20221020113541.0000490e@huawei.com> (raw)
In-Reply-To: <Y1BuLyxEKLIAgF+5@shikoro>
On Wed, 19 Oct 2022 23:37:51 +0200
Wolfram Sang <wsa-dev@sang-engineering.com> wrote:
> > I spent a little time trying to put together a Coccinelle script to
> > take care of everything but I eventually realized the size of the task
> > was larger than I was comfortable with. In particular, even though I
> > might be able to put together a script, I worry I don't have a good
> > way to test the resulting treewide changes to avoid regression.
>
> The coccinelle scripts are one thing. I am quite familiar with it, so I
> regard this as "work but doable". My main headache is that I am not sure
> about the best way to upstream the result. I'd like to avoid a flag-day
> where all drivers across all subsystems need to be converted, but I
> don't really see a way around it. Preparing such a branch and make sure
> it does not regress is quite some work on a moving target.
Horrendous though it is, you 'could' take it via a void * intermediate
step. That way all the warnings will disappear (I think).
You then move all the callers to providing u8 * then switch the function
to that. Could happen over several cycles with coccicheck moaning about
any new entries in the meantime.
Jonathan
>
>
next prev parent reply other threads:[~2022-10-20 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 15:34 [PATCH] i2c: Use u8 type in i2c transfer calls Jason Gerecke
2022-08-03 14:59 ` [PATCH v2] " Jason Gerecke
2022-08-03 16:46 ` Andy Shevchenko
2022-08-03 18:06 ` Jason Gerecke
2022-10-19 20:11 ` Wolfram Sang
2022-10-19 20:48 ` Jason Gerecke
2022-10-19 21:37 ` Wolfram Sang
2022-10-20 10:35 ` Jonathan Cameron [this message]
2022-08-06 14:44 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020113541.0000490e@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=jason.gerecke@wacom.com \
--cc=jic23@kernel.org \
--cc=killertofu@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.cheng@wacom.com \
--cc=pinglinux@gmail.com \
--cc=tatsunosuke.tobita@wacom.com \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.