From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2451E3C20 for ; Thu, 20 Oct 2022 13:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7120C433C1; Thu, 20 Oct 2022 13:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273136; bh=V2pyKMeZFmlh4KlmPfLIhmI5FqC3LJ2FfBL99fKAjw8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cA0jZ9ftozFRU1353+1RqCTqCZLfhC2nrk1U1ZbHuamTeBsDZDG6JCyDotdISJTXt /f7a+cDHPb9kWd8705ChLkmmt5BLwof3HvuIEmOQ9lgFChGcNPSbdd8f4xjqCJ0rej DdxejGxSaItMhvIzASLZd8KDJ46vpZKpyW6d4eSut2oXVxI8dbhUH29ecpu0F2bMiz oLeQx6wKoLPfQiivArL6vdxRze2EPWlJ8TA9AbLkaBdaxn34vN1sT0OrmJCVjGErQS XYtraHMNWOtTvWVY5rzthQQZf3QFoEY7bgzt0HzXazXG9DkYr4fB60NWrZJZgQ58tN KyXQUH/UgVXTA== From: Will Deacon To: kvmarm@lists.linux.dev Cc: Will Deacon , Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 05/25] KVM: arm64: Unify identifiers used to distinguish host and hypervisor Date: Thu, 20 Oct 2022 14:38:07 +0100 Message-Id: <20221020133827.5541-6-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221020133827.5541-1-will@kernel.org> References: <20221020133827.5541-1-will@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'pkvm_component_id' enum type provides constants to refer to the host and the hypervisor, yet this information is duplicated by the 'pkvm_hyp_id' constant. Remove the definition of 'pkvm_hyp_id' and move the 'pkvm_component_id' type definition to 'mem_protect.h' so that it can be used outside of the memory protection code, for example when initialising the owner for hypervisor-owned pages. Reviewed-by: Philippe Mathieu-Daudé Tested-by: Vincent Donnefort Signed-off-by: Will Deacon --- arch/arm64/kvm/hyp/include/nvhe/mem_protect.h | 6 +++++- arch/arm64/kvm/hyp/nvhe/mem_protect.c | 8 -------- arch/arm64/kvm/hyp/nvhe/setup.c | 2 +- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h index 80e99836eac7..f5705a1e972f 100644 --- a/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h +++ b/arch/arm64/kvm/hyp/include/nvhe/mem_protect.h @@ -51,7 +51,11 @@ struct host_kvm { }; extern struct host_kvm host_kvm; -extern const u8 pkvm_hyp_id; +/* This corresponds to page-table locking order */ +enum pkvm_component_id { + PKVM_ID_HOST, + PKVM_ID_HYP, +}; int __pkvm_prot_finalize(void); int __pkvm_host_share_hyp(u64 pfn); diff --git a/arch/arm64/kvm/hyp/nvhe/mem_protect.c b/arch/arm64/kvm/hyp/nvhe/mem_protect.c index 1e78acf9662e..ff86f5bd230f 100644 --- a/arch/arm64/kvm/hyp/nvhe/mem_protect.c +++ b/arch/arm64/kvm/hyp/nvhe/mem_protect.c @@ -26,8 +26,6 @@ struct host_kvm host_kvm; static struct hyp_pool host_s2_pool; -const u8 pkvm_hyp_id = 1; - static void host_lock_component(void) { hyp_spin_lock(&host_kvm.lock); @@ -380,12 +378,6 @@ void handle_host_mem_abort(struct kvm_cpu_context *host_ctxt) BUG_ON(ret && ret != -EAGAIN); } -/* This corresponds to locking order */ -enum pkvm_component_id { - PKVM_ID_HOST, - PKVM_ID_HYP, -}; - struct pkvm_mem_transition { u64 nr_pages; diff --git a/arch/arm64/kvm/hyp/nvhe/setup.c b/arch/arm64/kvm/hyp/nvhe/setup.c index 8f2726d7e201..0312c9c74a5a 100644 --- a/arch/arm64/kvm/hyp/nvhe/setup.c +++ b/arch/arm64/kvm/hyp/nvhe/setup.c @@ -212,7 +212,7 @@ static int fix_host_ownership_walker(u64 addr, u64 end, u32 level, state = pkvm_getstate(kvm_pgtable_hyp_pte_prot(pte)); switch (state) { case PKVM_PAGE_OWNED: - return host_stage2_set_owner_locked(phys, PAGE_SIZE, pkvm_hyp_id); + return host_stage2_set_owner_locked(phys, PAGE_SIZE, PKVM_ID_HYP); case PKVM_PAGE_SHARED_OWNED: prot = pkvm_mkstate(PKVM_HOST_MEM_PROT, PKVM_PAGE_SHARED_BORROWED); break; -- 2.38.0.413.g74048e4d9e-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51844C4332F for ; Thu, 20 Oct 2022 13:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y3rrMF/dAHntZj+6C1iOYyx6o4f4aQnMnHmqyGP4i98=; b=MXJmYIFyDYrCVL zgX8jiXDGQhcq7/n2j9P1/TcVH2ga57lVbqsrceQBZHYTITdl1YMatADIZmFzhDk097f0YZcAx9ZZ ByZt16Xrn3cPA+zD43L4WU+pInbi6Lc4UZyhwMDdg91Hzx6PCOQsLAVFPh87rR7ZoNAUynWXacrzI ltSDoU84KVzITFWi8ozg04wcLwhvjg6hQe694DRQ80CLEfdXxKWmK4QD/ouCJk2pGo7qaj8fQR1I5 9rvKQEPzDNRpuLtIiKDPIPKpf2wbL3DEgElR+ImGLPiX++Z/BfLsSnpoQTPsiYzGlwL5SR4R+OLDm CsYv+OX6BkDk190viKvQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olVvg-00Fkf5-16; Thu, 20 Oct 2022 13:49:49 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olVlB-00Fa2L-4g for linux-arm-kernel@lists.infradead.org; Thu, 20 Oct 2022 13:38:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9203161B96; Thu, 20 Oct 2022 13:38:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7120C433C1; Thu, 20 Oct 2022 13:38:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273136; bh=V2pyKMeZFmlh4KlmPfLIhmI5FqC3LJ2FfBL99fKAjw8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cA0jZ9ftozFRU1353+1RqCTqCZLfhC2nrk1U1ZbHuamTeBsDZDG6JCyDotdISJTXt /f7a+cDHPb9kWd8705ChLkmmt5BLwof3HvuIEmOQ9lgFChGcNPSbdd8f4xjqCJ0rej DdxejGxSaItMhvIzASLZd8KDJ46vpZKpyW6d4eSut2oXVxI8dbhUH29ecpu0F2bMiz oLeQx6wKoLPfQiivArL6vdxRze2EPWlJ8TA9AbLkaBdaxn34vN1sT0OrmJCVjGErQS XYtraHMNWOtTvWVY5rzthQQZf3QFoEY7bgzt0HzXazXG9DkYr4fB60NWrZJZgQ58tN KyXQUH/UgVXTA== From: Will Deacon To: kvmarm@lists.linux.dev Cc: Will Deacon , Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , James Morse , Chao Peng , Quentin Perret , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Oliver Upton , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 05/25] KVM: arm64: Unify identifiers used to distinguish host and hypervisor Date: Thu, 20 Oct 2022 14:38:07 +0100 Message-Id: <20221020133827.5541-6-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20221020133827.5541-1-will@kernel.org> References: <20221020133827.5541-1-will@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_063857_319119_FCC5A5D0 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhlICdwa3ZtX2NvbXBvbmVudF9pZCcgZW51bSB0eXBlIHByb3ZpZGVzIGNvbnN0YW50cyB0byBy ZWZlciB0byB0aGUKaG9zdCBhbmQgdGhlIGh5cGVydmlzb3IsIHlldCB0aGlzIGluZm9ybWF0aW9u IGlzIGR1cGxpY2F0ZWQgYnkgdGhlCidwa3ZtX2h5cF9pZCcgY29uc3RhbnQuCgpSZW1vdmUgdGhl IGRlZmluaXRpb24gb2YgJ3Brdm1faHlwX2lkJyBhbmQgbW92ZSB0aGUgJ3Brdm1fY29tcG9uZW50 X2lkJwp0eXBlIGRlZmluaXRpb24gdG8gJ21lbV9wcm90ZWN0LmgnIHNvIHRoYXQgaXQgY2FuIGJl IHVzZWQgb3V0c2lkZSBvZgp0aGUgbWVtb3J5IHByb3RlY3Rpb24gY29kZSwgZm9yIGV4YW1wbGUg d2hlbiBpbml0aWFsaXNpbmcgdGhlIG93bmVyIGZvcgpoeXBlcnZpc29yLW93bmVkIHBhZ2VzLgoK UmV2aWV3ZWQtYnk6IFBoaWxpcHBlIE1hdGhpZXUtRGF1ZMOpIDxwaGlsbWRAbGluYXJvLm9yZz4K VGVzdGVkLWJ5OiBWaW5jZW50IERvbm5lZm9ydCA8dmRvbm5lZm9ydEBnb29nbGUuY29tPgpTaWdu ZWQtb2ZmLWJ5OiBXaWxsIERlYWNvbiA8d2lsbEBrZXJuZWwub3JnPgotLS0KIGFyY2gvYXJtNjQv a3ZtL2h5cC9pbmNsdWRlL252aGUvbWVtX3Byb3RlY3QuaCB8IDYgKysrKystCiBhcmNoL2FybTY0 L2t2bS9oeXAvbnZoZS9tZW1fcHJvdGVjdC5jICAgICAgICAgfCA4IC0tLS0tLS0tCiBhcmNoL2Fy bTY0L2t2bS9oeXAvbnZoZS9zZXR1cC5jICAgICAgICAgICAgICAgfCAyICstCiAzIGZpbGVzIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJj aC9hcm02NC9rdm0vaHlwL2luY2x1ZGUvbnZoZS9tZW1fcHJvdGVjdC5oIGIvYXJjaC9hcm02NC9r dm0vaHlwL2luY2x1ZGUvbnZoZS9tZW1fcHJvdGVjdC5oCmluZGV4IDgwZTk5ODM2ZWFjNy4uZjU3 MDVhMWU5NzJmIDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2bS9oeXAvaW5jbHVkZS9udmhlL21l bV9wcm90ZWN0LmgKKysrIGIvYXJjaC9hcm02NC9rdm0vaHlwL2luY2x1ZGUvbnZoZS9tZW1fcHJv dGVjdC5oCkBAIC01MSw3ICs1MSwxMSBAQCBzdHJ1Y3QgaG9zdF9rdm0gewogfTsKIGV4dGVybiBz dHJ1Y3QgaG9zdF9rdm0gaG9zdF9rdm07CiAKLWV4dGVybiBjb25zdCB1OCBwa3ZtX2h5cF9pZDsK Ky8qIFRoaXMgY29ycmVzcG9uZHMgdG8gcGFnZS10YWJsZSBsb2NraW5nIG9yZGVyICovCitlbnVt IHBrdm1fY29tcG9uZW50X2lkIHsKKwlQS1ZNX0lEX0hPU1QsCisJUEtWTV9JRF9IWVAsCit9Owog CiBpbnQgX19wa3ZtX3Byb3RfZmluYWxpemUodm9pZCk7CiBpbnQgX19wa3ZtX2hvc3Rfc2hhcmVf aHlwKHU2NCBwZm4pOwpkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rdm0vaHlwL252aGUvbWVtX3By b3RlY3QuYyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL21lbV9wcm90ZWN0LmMKaW5kZXggMWU3 OGFjZjk2NjJlLi5mZjg2ZjViZDIzMGYgMTAwNjQ0Ci0tLSBhL2FyY2gvYXJtNjQva3ZtL2h5cC9u dmhlL21lbV9wcm90ZWN0LmMKKysrIGIvYXJjaC9hcm02NC9rdm0vaHlwL252aGUvbWVtX3Byb3Rl Y3QuYwpAQCAtMjYsOCArMjYsNiBAQCBzdHJ1Y3QgaG9zdF9rdm0gaG9zdF9rdm07CiAKIHN0YXRp YyBzdHJ1Y3QgaHlwX3Bvb2wgaG9zdF9zMl9wb29sOwogCi1jb25zdCB1OCBwa3ZtX2h5cF9pZCA9 IDE7Ci0KIHN0YXRpYyB2b2lkIGhvc3RfbG9ja19jb21wb25lbnQodm9pZCkKIHsKIAloeXBfc3Bp bl9sb2NrKCZob3N0X2t2bS5sb2NrKTsKQEAgLTM4MCwxMiArMzc4LDYgQEAgdm9pZCBoYW5kbGVf aG9zdF9tZW1fYWJvcnQoc3RydWN0IGt2bV9jcHVfY29udGV4dCAqaG9zdF9jdHh0KQogCUJVR19P TihyZXQgJiYgcmV0ICE9IC1FQUdBSU4pOwogfQogCi0vKiBUaGlzIGNvcnJlc3BvbmRzIHRvIGxv Y2tpbmcgb3JkZXIgKi8KLWVudW0gcGt2bV9jb21wb25lbnRfaWQgewotCVBLVk1fSURfSE9TVCwK LQlQS1ZNX0lEX0hZUCwKLX07Ci0KIHN0cnVjdCBwa3ZtX21lbV90cmFuc2l0aW9uIHsKIAl1NjQJ CQkJbnJfcGFnZXM7CiAKZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL3NldHVw LmMgYi9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9zZXR1cC5jCmluZGV4IDhmMjcyNmQ3ZTIwMS4u MDMxMmM5Yzc0YTVhIDEwMDY0NAotLS0gYS9hcmNoL2FybTY0L2t2bS9oeXAvbnZoZS9zZXR1cC5j CisrKyBiL2FyY2gvYXJtNjQva3ZtL2h5cC9udmhlL3NldHVwLmMKQEAgLTIxMiw3ICsyMTIsNyBA QCBzdGF0aWMgaW50IGZpeF9ob3N0X293bmVyc2hpcF93YWxrZXIodTY0IGFkZHIsIHU2NCBlbmQs IHUzMiBsZXZlbCwKIAlzdGF0ZSA9IHBrdm1fZ2V0c3RhdGUoa3ZtX3BndGFibGVfaHlwX3B0ZV9w cm90KHB0ZSkpOwogCXN3aXRjaCAoc3RhdGUpIHsKIAljYXNlIFBLVk1fUEFHRV9PV05FRDoKLQkJ cmV0dXJuIGhvc3Rfc3RhZ2UyX3NldF9vd25lcl9sb2NrZWQocGh5cywgUEFHRV9TSVpFLCBwa3Zt X2h5cF9pZCk7CisJCXJldHVybiBob3N0X3N0YWdlMl9zZXRfb3duZXJfbG9ja2VkKHBoeXMsIFBB R0VfU0laRSwgUEtWTV9JRF9IWVApOwogCWNhc2UgUEtWTV9QQUdFX1NIQVJFRF9PV05FRDoKIAkJ cHJvdCA9IHBrdm1fbWtzdGF0ZShQS1ZNX0hPU1RfTUVNX1BST1QsIFBLVk1fUEFHRV9TSEFSRURf Qk9SUk9XRUQpOwogCQlicmVhazsKLS0gCjIuMzguMC40MTMuZzc0MDQ4ZTRkOWUtZ29vZwoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK