From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F66C4321E for ; Thu, 20 Oct 2022 13:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbiJTNqL (ORCPT ); Thu, 20 Oct 2022 09:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229786AbiJTNqG (ORCPT ); Thu, 20 Oct 2022 09:46:06 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCECC11874B; Thu, 20 Oct 2022 06:45:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D34C4CE252D; Thu, 20 Oct 2022 13:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AC2C433C1; Thu, 20 Oct 2022 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273549; bh=gEzBsG2afAcJArkvwrtS1d1ZrUezVmRH4opGNtVPXAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VJGp3AgHy1aLrltfoH3ZUIY2vPiG8odz2T6+x6jMCxcJgZCwTqS9qB3icoBC8o4E8 E1gfpoW8H0h3qQq/0/EZYuKYCvQC8HL2tkyrpL4XwUeqKy9JVjs4nQoNI/bL0fqMMC fht4bNrhgVpd8SagpFnXZ9RE9junpC95FZ9mZIXzSFLwxrvemWT4v9YJzydgYmRwr9 Dq/0vR7MpzhoHTTfYTeffDWxoum67vJnPgSuWd0+edba3zhaABe6sytQ7LWcvC1QV0 OeDSrpxLauYQmP8C3WM0IafIX95qvt1v+oz6aA+EnOZHYUsc8+crMpW+Mx2cnmWOWH H+9jYGQE6tu6w== Date: Thu, 20 Oct 2022 08:45:47 -0500 From: Bjorn Helgaas To: Conor Dooley Cc: kernel test robot , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Heiko Stuebner , linux-pci@vger.kernel.org, Lorenzo Pieralisi , llvm@lists.linux.dev, Minghuan Lian , Thierry Reding , Thomas Petazzoni , Bharat Kumar Gogada , Toan Le , linux-riscv@lists.infradead.org, Kishon Vijay Abraham I , Rob Herring , Linus Walleij , Joyce Ooi , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Shawn Lin , Ray Jui , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Mingkai Hu , Roy Zang , Michal Simek , kbuild-all@lists.01.org, Scott Branden , Daire McNamara , linux-kernel@vger.kernel.org, Tom Joseph , linuxppc-dev@lists.ozlabs.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Message-ID: <20221020134547.GA94120@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BA03C4332F for ; Thu, 20 Oct 2022 14:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=/na44zMpI0cB2nwpWMHOsAP7mLgPm6K+yNHzqPvv73Y=; b=MqCsGDNnfUdVEc NCY1WUYcTzjuzWb+sXp/ZiOefpmdIcdJUSV6jlepdCQErp5ONQ4yYS/ws5U8Is0VUG+NGInvHy8wR FQkY57lfw/N14sERGBdU0iXtH3w0D2qtscE8DS4NzaPSuAZ5Cv5r0ooX5ddZKGtuXiv3YQ8ES3T7L XxSBteKx8rwcPUM3xj1/FyqwwS9I6JHxfOmT9FkgeuTLHfy4u3Gaq7uFqfY+Eb5cyq+B85jKChJOJ zZj1xl+wfccKtL3uFZ6yNUJ00v2RDx6TGnKdb5Oy5YDokvMo2sYEih5UiJS73KEyNH5RhR/Z/fbJ6 +7wbBWzEEaMJJ1Qcny+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olWII-00FwSF-01; Thu, 20 Oct 2022 14:13:10 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olVrr-00Fgt0-Kg; Thu, 20 Oct 2022 13:45:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4040CB82750; Thu, 20 Oct 2022 13:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AC2C433C1; Thu, 20 Oct 2022 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273549; bh=gEzBsG2afAcJArkvwrtS1d1ZrUezVmRH4opGNtVPXAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VJGp3AgHy1aLrltfoH3ZUIY2vPiG8odz2T6+x6jMCxcJgZCwTqS9qB3icoBC8o4E8 E1gfpoW8H0h3qQq/0/EZYuKYCvQC8HL2tkyrpL4XwUeqKy9JVjs4nQoNI/bL0fqMMC fht4bNrhgVpd8SagpFnXZ9RE9junpC95FZ9mZIXzSFLwxrvemWT4v9YJzydgYmRwr9 Dq/0vR7MpzhoHTTfYTeffDWxoum67vJnPgSuWd0+edba3zhaABe6sytQ7LWcvC1QV0 OeDSrpxLauYQmP8C3WM0IafIX95qvt1v+oz6aA+EnOZHYUsc8+crMpW+Mx2cnmWOWH H+9jYGQE6tu6w== Date: Thu, 20 Oct 2022 08:45:47 -0500 From: Bjorn Helgaas To: Conor Dooley Cc: kernel test robot , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Heiko Stuebner , linux-pci@vger.kernel.org, Lorenzo Pieralisi , llvm@lists.linux.dev, Minghuan Lian , Thierry Reding , Thomas Petazzoni , Bharat Kumar Gogada , Toan Le , linux-riscv@lists.infradead.org, Kishon Vijay Abraham I , Rob Herring , Linus Walleij , Joyce Ooi , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Shawn Lin , Ray Jui , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Mingkai Hu , Roy Zang , Michal Simek , kbuild-all@lists.01.org, Scott Branden , Daire McNamara , linux-kernel@vger.kernel.org, Tom Joseph , linuxppc-dev@lists.ozlabs.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Message-ID: <20221020134547.GA94120@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_064551_877796_AB6EC28A X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A8D4C4332F for ; Thu, 20 Oct 2022 13:46:46 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MtTR86X5Cz3dqd for ; Fri, 21 Oct 2022 00:46:44 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=VJGp3AgH; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4601:e00::1; helo=ams.source.kernel.org; envelope-from=helgaas@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=VJGp3AgH; dkim-atps=neutral Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MtTQ85F4Zz3bhZ for ; Fri, 21 Oct 2022 00:45:52 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4040CB82750; Thu, 20 Oct 2022 13:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AC2C433C1; Thu, 20 Oct 2022 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273549; bh=gEzBsG2afAcJArkvwrtS1d1ZrUezVmRH4opGNtVPXAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VJGp3AgHy1aLrltfoH3ZUIY2vPiG8odz2T6+x6jMCxcJgZCwTqS9qB3icoBC8o4E8 E1gfpoW8H0h3qQq/0/EZYuKYCvQC8HL2tkyrpL4XwUeqKy9JVjs4nQoNI/bL0fqMMC fht4bNrhgVpd8SagpFnXZ9RE9junpC95FZ9mZIXzSFLwxrvemWT4v9YJzydgYmRwr9 Dq/0vR7MpzhoHTTfYTeffDWxoum67vJnPgSuWd0+edba3zhaABe6sytQ7LWcvC1QV0 OeDSrpxLauYQmP8C3WM0IafIX95qvt1v+oz6aA+EnOZHYUsc8+crMpW+Mx2cnmWOWH H+9jYGQE6tu6w== Date: Thu, 20 Oct 2022 08:45:47 -0500 From: Bjorn Helgaas To: Conor Dooley Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Message-ID: <20221020134547.GA94120@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Heiko Stuebner , linux-pci@vger.kernel.org, Linus Walleij , llvm@lists.linux.dev, Minghuan Lian , Thierry Reding , Thomas Petazzoni , Bharat Kumar Gogada , Toan Le , linux-riscv@lists.infradead.org, Kishon Vijay Abraham I , Rob Herring , kernel test robot , Joyce Ooi , Jonathan Hunter , bcm-kernel-feedback-list@broadcom.com, Mingkai Hu , Shawn Lin , Lorenzo Pieralisi , Ray Jui , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roy Zang , Michal Simek , kbuild-all@lists.01.org, Scott Branden , Daire McNamara , Pali =?iso-8859-1?Q?Roh=E1r?= , linux-kernel@vger.kernel.org, Tom Joseph , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5376C433FE for ; Thu, 20 Oct 2022 14:13:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=UpJf8XVGP5dC4JNSIw9Oi4nqnOPFTeIUMs3KTwypc9c=; b=Vbu9tZMF2iC5eZ wFLJ8DsJnrGXW5b2bq51/zw6DrtxWWoYnutrb+aDyKlOeKgtWaEdibzbqjq2SOs5lrUGpsp82lCzU QiaEva8gz6RBLgtK7yZuAkdd11x9iyGy6Ltt1HZ4OMf1X+mNhNzO4JJhDnbWnugUopgRYikQtXweT B6kc9kB7gcgUoZ+E27aDYfrEzDGDI6XtOEDnPcdCuMXYHw+FlN9Xr3m638y6CktPS0gk89SdhtSni nKcMLHTbvl1yWgiBe2Pgb2HylMjFVv06OFxReVaJ7SZz4+Vxx2ADnoacI9x5JpZEYzXGotMKbr2Tm O2g5rHyQWtGWx/thexWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olWHt-00Fw4t-4Q; Thu, 20 Oct 2022 14:12:45 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olVrr-00Fgt0-Kg; Thu, 20 Oct 2022 13:45:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4040CB82750; Thu, 20 Oct 2022 13:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4AC2C433C1; Thu, 20 Oct 2022 13:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666273549; bh=gEzBsG2afAcJArkvwrtS1d1ZrUezVmRH4opGNtVPXAQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VJGp3AgHy1aLrltfoH3ZUIY2vPiG8odz2T6+x6jMCxcJgZCwTqS9qB3icoBC8o4E8 E1gfpoW8H0h3qQq/0/EZYuKYCvQC8HL2tkyrpL4XwUeqKy9JVjs4nQoNI/bL0fqMMC fht4bNrhgVpd8SagpFnXZ9RE9junpC95FZ9mZIXzSFLwxrvemWT4v9YJzydgYmRwr9 Dq/0vR7MpzhoHTTfYTeffDWxoum67vJnPgSuWd0+edba3zhaABe6sytQ7LWcvC1QV0 OeDSrpxLauYQmP8C3WM0IafIX95qvt1v+oz6aA+EnOZHYUsc8+crMpW+Mx2cnmWOWH H+9jYGQE6tu6w== Date: Thu, 20 Oct 2022 08:45:47 -0500 From: Bjorn Helgaas To: Conor Dooley Cc: kernel test robot , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Heiko Stuebner , linux-pci@vger.kernel.org, Lorenzo Pieralisi , llvm@lists.linux.dev, Minghuan Lian , Thierry Reding , Thomas Petazzoni , Bharat Kumar Gogada , Toan Le , linux-riscv@lists.infradead.org, Kishon Vijay Abraham I , Rob Herring , Linus Walleij , Joyce Ooi , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Shawn Lin , Ray Jui , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Mingkai Hu , Roy Zang , Michal Simek , kbuild-all@lists.01.org, Scott Branden , Daire McNamara , linux-kernel@vger.kernel.org, Tom Joseph , linuxppc-dev@lists.ozlabs.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Message-ID: <20221020134547.GA94120@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_064551_877796_AB6EC28A X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomplete definition of type 'struct irq_domain' > > struct mc_pcie *port = domain->host_data; > > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2969312049223122223==" MIME-Version: 1.0 From: Bjorn Helgaas To: kbuild-all@lists.01.org Subject: Re: [PATCH] PCI: Remove unnecessary of_irq.h includes Date: Thu, 20 Oct 2022 08:45:47 -0500 Message-ID: <20221020134547.GA94120@bhelgaas> In-Reply-To: List-Id: --===============2969312049223122223== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable [+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > = > > I love your patch! Yet something to improve: > > = > > >> drivers/pci/controller/pcie-microchip-host.c:473:31: error: incomple= te definition of type 'struct irq_domain' > > struct mc_pcie *port =3D domain->host_data; > = > That's what I get for only visually inspecting the patch before Acking > it.. Un-ack I suppose. No problem! I think what happened is the pcie-microchip-host.c uses irq_domain_add_linear() so it needs , but it currently gets it via , which it doesn't otherwise need. I added a preparatory patch to include explicitly, but I haven't been able to cross-build either riscv or ia64 to verify this fix. I'll wait a few days and post an updated series for the 0-day bot to test. Same situation for pcie-altera-msi.c. pci-mvebu.c also relies on getting via , but it actually depends on of_irq.h, so I'll just add an irqdomain.h include there. Bjorn --===============2969312049223122223==--