All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: Nico Boehr <nrb@linux.ibm.com>,
	kvm@vger.kernel.org, seiden@linux.ibm.com, scgl@linux.ibm.com,
	thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v1 1/2] lib: s390x: terminate if PGM interrupt in interrupt handler
Date: Thu, 20 Oct 2022 13:45:59 +0200	[thread overview]
Message-ID: <20221020134559.609bba25@p-imbrenda> (raw)
In-Reply-To: <593e6d2f-e857-48c6-fa2d-158b83b4db4f@linux.ibm.com>

On Thu, 20 Oct 2022 13:19:36 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 10/20/22 10:57, Claudio Imbrenda wrote:
> > On Thu, 20 Oct 2022 09:58:05 +0200
> > Nico Boehr <nrb@linux.ibm.com> wrote:
> >   
> >> Quoting Claudio Imbrenda (2022-10-19 11:51:28)
> >> [...]  
> >>> I was thinking that we set pgm_int_expected = false so we would catch a
> >>> wild program interrupt there, but in hindsight maybe it's better to set
> >>> in_interrupt_handler = true there so we can abort immediately  
> >>
> >> Oh right I missed that. I think how it is right now is nicer because we will get a nice message on the console, right?  
> > 
> > which will generate more interrupts
> > 
> > @Janosch do you think it's better with or without setting
> > in_interrupt_handler in the pgm interrupt handler?
> >   
> 
> Any reason why you didn't set it in CALL_INT_HANDLER?

because then it will always be set whenever we get a PGM, the if will
always be true

> 
> >>
> >> In this case:
> >> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>  
> >   


  reply	other threads:[~2022-10-20 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 14:09 [kvm-unit-tests PATCH v1 0/2] s390x misc fixes Claudio Imbrenda
2022-10-18 14:09 ` [kvm-unit-tests PATCH v1 1/2] lib: s390x: terminate if PGM interrupt in interrupt handler Claudio Imbrenda
2022-10-19  7:34   ` Nico Boehr
2022-10-19  9:51     ` Claudio Imbrenda
2022-10-20  7:58       ` Nico Boehr
2022-10-20  8:57         ` Claudio Imbrenda
2022-10-20 11:19           ` Janosch Frank
2022-10-20 11:45             ` Claudio Imbrenda [this message]
2022-10-20 12:12               ` Janosch Frank
2022-10-18 14:09 ` [kvm-unit-tests PATCH v1 2/2] s390x: uv-host: fix allocation of UV memory Claudio Imbrenda
2022-10-19  6:34   ` Janosch Frank
2022-10-20  8:07   ` Steffen Eiden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020134559.609bba25@p-imbrenda \
    --to=imbrenda@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=nrb@linux.ibm.com \
    --cc=scgl@linux.ibm.com \
    --cc=seiden@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.