From: Stanislaw Gruszka <stf_xl@wp.pl>
To: "Colin King (gmail)" <colin.i.king@gmail.com>
Cc: "Tomislav Požega" <pozega.tomislav@gmail.com>,
"Helmut Schaa" <helmut.schaa@googlemail.com>,
"Kalle Valo" <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: wifi: rt2x00: add TX LOFT calibration for MT7620
Date: Thu, 20 Oct 2022 17:15:22 +0200 [thread overview]
Message-ID: <20221020151522.GA99236@wp.pl> (raw)
In-Reply-To: <01410678-ab7d-1733-8d5a-e06d1a4b6c9e@gmail.com>
On Thu, Oct 20, 2022 at 02:45:22PM +0100, Colin King (gmail) wrote:
> I noticed a signed / unsigned comparison warning when building linux-next
> with clang. I believe it was introduced in the following commit:
>
> commit dab902fe1d29dc0fa1dccc8d13dc89ffbf633881
> Author: Tomislav Požega <pozega.tomislav@gmail.com>
> Date: Sat Sep 17 21:28:43 2022 +0100
>
> wifi: rt2x00: add TX LOFT calibration for MT7620
>
>
> The warning is as follows:
>
> drivers/net/wireless/ralink/rt2x00/rt2800lib.c:9472:15: warning: result of
> comparison of constant -7 with expression of type 'char' is always false
> [-Wtautological-constant-out-of-range-compare]
> gerr = (gerr < -0x07) ? -0x07 : (gerr > 0x05) ? 0x05 : gerr;
This was very currently addressed:
https://lore.kernel.org/linux-wireless/20221019155541.3410813-1-Jason@zx2c4.com/
Regards
Stanislaw
next prev parent reply other threads:[~2022-10-20 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 13:45 wifi: rt2x00: add TX LOFT calibration for MT7620 Colin King (gmail)
2022-10-20 15:15 ` Stanislaw Gruszka [this message]
2022-10-20 15:16 ` Colin King (gmail)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020151522.GA99236@wp.pl \
--to=stf_xl@wp.pl \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=helmut.schaa@googlemail.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pozega.tomislav@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.