All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 1/4] hwmon: (jc42) Convert register access to use an I2C regmap
Date: Thu, 20 Oct 2022 15:07:01 -0700	[thread overview]
Message-ID: <20221020220701.GF4035307@roeck-us.net> (raw)
In-Reply-To: <20221020210320.1624617-2-martin.blumenstingl@googlemail.com>

On Thu, Oct 20, 2022 at 11:03:17PM +0200, Martin Blumenstingl wrote:
> Switch the jc42 driver to use an I2C regmap to access the registers.
> This is done in preparation for improving the caching of registers and
> to restore the cached limits during system resume.
> 

I would suggest to combine patch 1 and 2 and drop local caching entirely
in a single patch.

Thanks,
Guenter

  reply	other threads:[~2022-10-20 22:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20 21:03 [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 1/4] hwmon: (jc42) Convert register access to use an I2C regmap Martin Blumenstingl
2022-10-20 22:07   ` Guenter Roeck [this message]
2022-10-20 21:03 ` [RFC PATCH v2 2/4] hwmon: (jc42) Convert to regmap's built-in caching Martin Blumenstingl
2022-10-20 22:04   ` Guenter Roeck
2022-10-20 21:03 ` [RFC PATCH v2 3/4] hwmon: (jc42) Restore the min/max/critical temperatures on resume Martin Blumenstingl
2022-10-20 21:03 ` [RFC PATCH v2 4/4] hwmon: (jc42) Don't cache the temperature register Martin Blumenstingl
2022-10-20 22:14   ` Guenter Roeck
2022-10-20 22:22     ` Martin Blumenstingl
2022-10-20 22:37       ` Guenter Roeck
2022-10-20 22:16 ` [RFC PATCH v2 0/4] hwmon: (jc42) regmap conversion and resume fix Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020220701.GF4035307@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.