From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8AEC43217 for ; Fri, 21 Oct 2022 01:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229867AbiJUBL0 (ORCPT ); Thu, 20 Oct 2022 21:11:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229739AbiJUBLZ (ORCPT ); Thu, 20 Oct 2022 21:11:25 -0400 Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 297B822C81D; Thu, 20 Oct 2022 18:11:25 -0700 (PDT) Received: by mail-oi1-f173.google.com with SMTP id g130so1553502oia.13; Thu, 20 Oct 2022 18:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lq/2f5Qjta2IeYsuNeBBwS2JijLfeJeS9crwH8APXzw=; b=Z1Mgwxr8+mhE7S0ZrP7Xz8qIoLxgE2oW+qMlnAOUES9TUyLB4aT59mBGYDxgBOeCrm VmEFdvq6cJGLY0+DWEZZ+V+zH2sIEzfAAEHE5DGe8YYIuYhZPn9Ewc1l/N68zNihAXfN MJOiOmISc0QuzwEV4073VD3tfOnNKMqrJghzVAThWqpap4uqgbY/c7ZdftMJtcbUhBrB 6pDvPCGyAQUDMAfP3Gw/1/6SBhPQjjnt30vyjDlP0R0DrI3XR/xB8hUAfP2i1dxknWXW qvw2RUXQLcRPbkfNNmL4/zCxpz/0zztor8XOK7fzKg31g9wxvbrjOWxMOttVwTcgp3dJ z2TQ== X-Gm-Message-State: ACrzQf19y3pMaWCVR9BQR/AxdiYniu0ou1ySolrUpLXrYf4izWei5I4L gtAR3aDF8CZrlnkukyxAyg== X-Google-Smtp-Source: AMsMyM7ufduaJ4RrO5rQF62MQyAxwcMCb1wyId7oqmw2ywn9Lwx9e+UFcDNaI+UfDBT16P/XXm2RAA== X-Received: by 2002:a05:6808:bcb:b0:355:219c:3cf1 with SMTP id o11-20020a0568080bcb00b00355219c3cf1mr8984755oik.121.1666314684389; Thu, 20 Oct 2022 18:11:24 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m8-20020a056870a10800b00127a6357bd5sm9507965oae.49.2022.10.20.18.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 18:11:23 -0700 (PDT) Received: (nullmailer pid 2108245 invoked by uid 1000); Fri, 21 Oct 2022 01:11:25 -0000 Date: Thu, 20 Oct 2022 20:11:25 -0500 From: Rob Herring To: Sai Krishna Potthuri Cc: Linus Walleij , Michal Simek , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, saikrishna12468@gmail.com, git@amd.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration" Message-ID: <20221021011125.GA2104528-robh@kernel.org> References: <20221017130303.21746-1-sai.krishna.potthuri@amd.com> <20221017130303.21746-3-sai.krishna.potthuri@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221017130303.21746-3-sai.krishna.potthuri@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Oct 17, 2022 at 06:33:03PM +0530, Sai Krishna Potthuri wrote: > This reverts commit 133ad0d9af99bdca90705dadd8d31c20bfc9919f. > > On systems with older PMUFW (Xilinx ZynqMP Platform Management Firmware) > using these pinctrl properties can cause system hang because there is > missing feature autodetection. > When this feature is implemented, support for these two properties should > bring back. So I'm going to get to review the revert of the revert at some point? Why do the properties need to be removed from the binding? They work on 'not older' firmware, right? Isn't just removing the driver support or removing from .dts files enough? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3479C4332F for ; Fri, 21 Oct 2022 01:12:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lV15QwQO/n6Grq5fy0Qglnno52szQWR+OyucILjI30c=; b=kdFMnjDe1znJlo GWg3IE27mxCfSAI+74bGUC/e767Wa72KZu2U9fFJrXPoZq7P0egxcbB93zHoOXv6Ok5w4hBspkpaJ W4mIpOoSmmlXDxAf1/hjG2VIMroSMZ5u4/r2Iy+49cXBXG1TTvZ1MDGXPie2TwLAaEAleH8EbDk7P YQLaqvbdLVUbwuIy6s9fMxBdisAEb1Xt5Eev4YOVIuUI5wGJxw/2nExvQSQO8vHv4kw5l5BpMxNrg 6OddhT1PkmWPbTZeQpcnc5XyF3aVCEiI7NNCYkaDzZKOE3rQXM44ZyHdE3Is8MDauvWWdmfVCBiSl 2P3foBo9ImdjuIxyy4AA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olgZM-003PWw-Va; Fri, 21 Oct 2022 01:11:29 +0000 Received: from mail-oi1-f180.google.com ([209.85.167.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olgZK-003PWG-PN for linux-arm-kernel@lists.infradead.org; Fri, 21 Oct 2022 01:11:27 +0000 Received: by mail-oi1-f180.google.com with SMTP id u15so1623659oie.2 for ; Thu, 20 Oct 2022 18:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lq/2f5Qjta2IeYsuNeBBwS2JijLfeJeS9crwH8APXzw=; b=sUQ5ocse8A+Ll1me5s0h1VmLMGbx7sTRnCVeJJXGvdpDtN+HFO5oQXsqsy0+BhgOcm nNEHw7agnbOb/bP7VeGyMYb9tVCFEeoFZVn07N9H/p2lCNgTFfnoi6qoJr86w0+CxJLX H9Z9OC69rEhXZdLG2fP3hdmHztar01tJE+XqueCRiEfWVkB/T5WZkIBiPujy3AP2WTRO nXgnxbOtdekc9hm7TQarVaQLjI7EchfljYGiPvygVNLWyaUSIyH3ocP8P0H2yuZdRcf8 3o5txwMfl8dTZwhiYu2ZeNRraN+C89E15xytFjbU5w2qpCCw0sq27Iay1ECHDa6ce6c/ rrQQ== X-Gm-Message-State: ACrzQf2mwFdSGuUGvC517ne80SfV+CUvdyUKsEEcD0UkYRdEd15TFi6F Bw/8DmQVY5LBcl/hzrkdtw== X-Google-Smtp-Source: AMsMyM7ufduaJ4RrO5rQF62MQyAxwcMCb1wyId7oqmw2ywn9Lwx9e+UFcDNaI+UfDBT16P/XXm2RAA== X-Received: by 2002:a05:6808:bcb:b0:355:219c:3cf1 with SMTP id o11-20020a0568080bcb00b00355219c3cf1mr8984755oik.121.1666314684389; Thu, 20 Oct 2022 18:11:24 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id m8-20020a056870a10800b00127a6357bd5sm9507965oae.49.2022.10.20.18.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Oct 2022 18:11:23 -0700 (PDT) Received: (nullmailer pid 2108245 invoked by uid 1000); Fri, 21 Oct 2022 01:11:25 -0000 Date: Thu, 20 Oct 2022 20:11:25 -0500 From: Rob Herring To: Sai Krishna Potthuri Cc: Linus Walleij , Michal Simek , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, saikrishna12468@gmail.com, git@amd.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] Revert "dt-bindings: pinctrl-zynqmp: Add output-enable configuration" Message-ID: <20221021011125.GA2104528-robh@kernel.org> References: <20221017130303.21746-1-sai.krishna.potthuri@amd.com> <20221017130303.21746-3-sai.krishna.potthuri@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221017130303.21746-3-sai.krishna.potthuri@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_181126_840532_49BD3D16 X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 17, 2022 at 06:33:03PM +0530, Sai Krishna Potthuri wrote: > This reverts commit 133ad0d9af99bdca90705dadd8d31c20bfc9919f. > > On systems with older PMUFW (Xilinx ZynqMP Platform Management Firmware) > using these pinctrl properties can cause system hang because there is > missing feature autodetection. > When this feature is implemented, support for these two properties should > bring back. So I'm going to get to review the revert of the revert at some point? Why do the properties need to be removed from the binding? They work on 'not older' firmware, right? Isn't just removing the driver support or removing from .dts files enough? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel