From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 7/7] net: sfp: get rid of DM7052 hack when enabling high power
Date: Fri, 21 Oct 2022 09:16:18 -0700 [thread overview]
Message-ID: <20221021091618.30c27249@kernel.org> (raw)
In-Reply-To: <Y1LAVAUSQJrmO+63@lunn.ch>
On Fri, 21 Oct 2022 17:52:52 +0200 Andrew Lunn wrote:
> On Wed, Oct 19, 2022 at 02:29:16PM +0100, Russell King (Oracle) wrote:
> > Since we no longer mis-detect high-power mode with the DM7052 module,
> > we no longer need the hack in sfp_module_enable_high_power(), and can
> > now switch this to use sfp_modify_u8().
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
FWIW there is a v2 of this, somewhat mis-subjected (pw-bot's
auto-Superseding logic missed it for example):
https://lore.kernel.org/all/E1oltef-00Fwwz-3t@rmk-PC.armlinux.org.uk/
next prev parent reply other threads:[~2022-10-21 16:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 13:28 [PATCH net-next 0/7] net: sfp: improve high power module implementation Russell King (Oracle)
2022-10-19 13:28 ` [PATCH net-next 1/7] dt-bindings: net: sff,sfp: update binding Russell King (Oracle)
2022-10-19 23:31 ` Rob Herring
2022-10-20 8:28 ` Russell King (Oracle)
2022-10-20 14:19 ` Rob Herring
2022-10-20 14:27 ` Rob Herring
2022-10-20 16:08 ` Russell King (Oracle)
2022-10-20 22:06 ` Rob Herring
2022-10-20 14:31 ` Russell King (Oracle)
2022-10-19 13:28 ` [PATCH net-next 2/7] net: sfp: check firmware provided max power Russell King (Oracle)
2022-10-21 15:44 ` Andrew Lunn
2022-10-19 13:28 ` [PATCH net-next 3/7] net: sfp: ignore power level 2 prior to SFF-8472 Rev 10.2 Russell King (Oracle)
2022-10-21 15:45 ` Andrew Lunn
2022-10-19 13:29 ` [PATCH net-next 4/7] net: sfp: ignore power level 3 prior to SFF-8472 Rev 11.4 Russell King (Oracle)
2022-10-21 15:46 ` Andrew Lunn
2022-10-19 13:29 ` [PATCH net-next 5/7] net: sfp: provide a definition for the power level select bit Russell King (Oracle)
2022-10-21 15:46 ` Andrew Lunn
2022-10-19 13:29 ` [PATCH net-next 6/7] net: sfp: add sfp_modify_u8() helper Russell King (Oracle)
2022-10-21 15:50 ` Andrew Lunn
2022-10-19 13:29 ` [PATCH net-next 7/7] net: sfp: get rid of DM7052 hack when enabling high power Russell King (Oracle)
2022-10-21 15:52 ` Andrew Lunn
2022-10-21 16:16 ` Jakub Kicinski [this message]
2022-10-21 19:14 ` Russell King (Oracle)
2022-10-21 15:42 ` [PATCH net-next 0/7] net: sfp: improve high power module implementation Andrew Lunn
-- strict thread matches above, loose matches on Subject: below --
2022-10-21 15:08 [PATCH net-next v2 " Russell King (Oracle)
2022-10-21 15:10 ` [PATCH net-next 7/7] net: sfp: get rid of DM7052 hack when enabling high power Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021091618.30c27249@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.