From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
bpf@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WARN: multiple IDs found for 'nf_conn': 92168, 117897 - using 92168
Date: Fri, 21 Oct 2022 22:36:12 -0700 [thread overview]
Message-ID: <20221021223612.42ba3122@kernel.org> (raw)
In-Reply-To: <Y1MQVbq2rjH/zPi2@krava>
On Fri, 21 Oct 2022 23:34:13 +0200 Jiri Olsa wrote:
> > You are right, they should be identical once PTR is deduplicated
> > properly. Sorry, was too quick to jump to conclusions. I was thinking
> > about situations explained by Alan.
> >
> > So, is this still an issue or this was fixed by [0]?
> >
> > [0] https://lore.kernel.org/bpf/1666364523-9648-1-git-send-email-alan.maguire@oracle.com/
>
> yes, it seems to be fixed by that
>
> Jakub,
> could you check with pahole fix [1]?
If you mean the warning from the subject then those do seem to be gone.
But if I'm completely honest I don't remember how I triggered them in
the first place :S There weren't there on every build for me.
The objtool warning is still here:
$ make PAHOLE=~/pahole O=build_allmodconfig/ -j 60 >/tmp/stdout 2>/tmp/stderr; \
cat /tmp/stderr
vmlinux.o: warning: objtool: ___ksymtab+bpf_dispatcher_xdp_func+0x0: data relocation to !ENDBR: bpf_dispatcher_xdp_func+0x0
vmlinux.o: warning: objtool: bpf_dispatcher_xdp+0xa0: data relocation to !ENDBR: bpf_dispatcher_xdp_func+0x0
next prev parent reply other threads:[~2022-10-22 5:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:05 objtool: bpf_dispatcher_xdp+0xa0: data relocation to !ENDBR: Jakub Kicinski
2022-10-04 4:49 ` WARN: multiple IDs found for 'nf_conn': 92168, 117897 - using 92168 Jakub Kicinski
2022-10-04 6:42 ` Jiri Olsa
2022-10-04 14:25 ` Jakub Kicinski
2022-10-05 9:45 ` Jiri Olsa
2022-10-05 15:44 ` Jakub Kicinski
2022-10-05 16:18 ` Jakub Kicinski
2022-10-05 20:07 ` Jiri Olsa
2022-10-13 15:05 ` Jakub Kicinski
2022-10-13 21:55 ` Jiri Olsa
2022-10-13 22:12 ` Jiri Olsa
2022-10-13 22:24 ` Andrii Nakryiko
2022-10-14 6:47 ` Jiri Olsa
2022-10-14 17:17 ` Alan Maguire
2022-10-16 13:07 ` Jiri Olsa
2022-10-21 18:18 ` Andrii Nakryiko
2022-10-21 21:34 ` Jiri Olsa
2022-10-22 5:36 ` Jakub Kicinski [this message]
2022-10-23 1:18 ` Alexei Starovoitov
2022-10-24 18:21 ` Jakub Kicinski
2022-10-04 14:46 ` Daniel Xu
2022-10-04 15:34 ` Jakub Kicinski
2022-10-18 15:11 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021223612.42ba3122@kernel.org \
--to=kuba@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olsajiri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.