From: Stefan Roesch <shr@devkernel.io>
To: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org
Cc: shr@devkernel.io, axboe@kernel.dk, clm@meta.com,
willy@infradead.org, hch@infradead.org
Subject: [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function.
Date: Mon, 24 Oct 2022 12:05:59 -0700 [thread overview]
Message-ID: <20221024190603.3987969-11-shr@devkernel.io> (raw)
In-Reply-To: <20221024190603.3987969-1-shr@devkernel.io>
This adds a function to return the specified value for min_bytes. It
converts the stored min_ratio of the bdi to the corresponding bytes
value. This is an approximation as it is based on the value that is
returned by global_dirty_limits(), which can change. The returned
value can be different than the value when the min_bytes value was set.
Signed-off-by: Stefan Roesch <shr@devkernel.io>
---
include/linux/backing-dev.h | 1 +
mm/page-writeback.c | 6 ++++++
2 files changed, 7 insertions(+)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index 5eb1ae3410b2..621329f25bbe 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -105,6 +105,7 @@ static inline unsigned long wb_stat_error(void)
/* BDI ratio is expressed as part per 1000 for finer granularity. */
#define BDI_RATIO_SCALE 10
+unsigned long long bdi_get_min_bytes(struct backing_dev_info *bdi);
unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi);
int bdi_set_min_ratio(struct backing_dev_info *bdi, unsigned int min_ratio);
int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio);
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 21d7c1880ea8..69fc2866e625 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -740,6 +740,12 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned int max_ratio)
}
EXPORT_SYMBOL(bdi_set_max_ratio);
+unsigned long long bdi_get_min_bytes(struct backing_dev_info *bdi)
+{
+ return bdi_get_bytes(bdi->min_ratio);
+}
+EXPORT_SYMBOL_GPL(bdi_get_min_bytes);
+
unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi)
{
return bdi_get_bytes(bdi->max_ratio);
--
2.30.2
next prev parent reply other threads:[~2022-10-24 21:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 19:05 [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-11-16 21:28 ` Andrew Morton
2022-11-19 0:01 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 02/14] mm: add knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 03/14] mm: document /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 04/14] mm: use part per 1000 for bdi ratios Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:03 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:10 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-10-24 19:05 ` [RFC PATCH v3 07/14] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:14 ` Stefan Roesch
2022-11-16 21:29 ` Andrew Morton
2022-11-19 0:16 ` Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 08/14] mm: add knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-24 19:05 ` [RFC PATCH v3 09/14] mm: document /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-24 19:05 ` Stefan Roesch [this message]
2022-11-16 21:29 ` [RFC PATCH v3 10/14] mm: add bdi_get_min_bytes() function Andrew Morton
2022-10-24 19:06 ` [RFC PATCH v3 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 13/14] mm: add /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-24 19:06 ` [RFC PATCH v3 14/14] mm: document " Stefan Roesch
2022-11-11 17:30 ` [RFC PATCH v3 00/14] mm/block: add bdi sysfs knobs Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221024190603.3987969-11-shr@devkernel.io \
--to=shr@devkernel.io \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=hch@infradead.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.