All of lore.kernel.org
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH 03/11] mm/damon/core: split out scheme stat update logic into a new function
Date: Mon, 24 Oct 2022 20:49:11 +0000	[thread overview]
Message-ID: <20221024204919.18524-4-sj@kernel.org> (raw)
In-Reply-To: <20221024204919.18524-1-sj@kernel.org>

The function for applying a given DAMON scheme action to a given DAMON
region, 'damos_apply_scheme()' is not quite short.  Make it better to
read by splitting out the stat update logic into a new function.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/core.c | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index c1a912bc46ae..3a810c6e26bc 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -755,6 +755,16 @@ static bool damos_skip_charged_region(struct damon_target *t,
 	return false;
 }
 
+static void damos_update_stat(struct damos *s,
+		unsigned long sz_tried, unsigned long sz_applied)
+{
+	s->stat.nr_tried++;
+	s->stat.sz_tried += sz_tried;
+	if (sz_applied)
+		s->stat.nr_applied++;
+	s->stat.sz_applied += sz_applied;
+}
+
 static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,
 		struct damon_region *r, struct damos *s)
 {
@@ -786,11 +796,7 @@ static void damos_apply_scheme(struct damon_ctx *c, struct damon_target *t,
 		r->age = 0;
 
 update_stat:
-	s->stat.nr_tried++;
-	s->stat.sz_tried += sz;
-	if (sz_applied)
-		s->stat.nr_applied++;
-	s->stat.sz_applied += sz_applied;
+	damos_update_stat(s, sz, sz_applied);
 }
 
 static void damon_do_apply_schemes(struct damon_ctx *c,
-- 
2.25.1


  parent reply	other threads:[~2022-10-24 20:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 20:49 [PATCH 00/11] mm/damon: cleanup and refactoring code SeongJae Park
2022-10-24 20:49 ` [PATCH 01/11] mm/damon/core: split out DAMOS-charged region skip logic into a new function SeongJae Park
2022-10-24 20:49 ` [PATCH 02/11] mm/damon/core: split damos application " SeongJae Park
2022-10-24 20:49 ` SeongJae Park [this message]
2022-10-24 20:49 ` [PATCH 04/11] mm/damon/core: split out scheme quota adjustment " SeongJae Park
2022-10-24 20:49 ` [PATCH 05/11] mm/damon/sysfs: use damon_addr_range for regions' start and end values SeongJae Park
2022-10-24 20:49 ` [PATCH 06/11] mm/damon/sysfs: remove parameters of damon_sysfs_region_alloc() SeongJae Park
2022-10-24 20:49 ` [PATCH 07/11] mm/damon/sysfs: move sysfs_lock to common module SeongJae Park
2022-10-24 20:49 ` [PATCH 08/11] mm/damon/sysfs: move unsigned long range directory " SeongJae Park
2022-10-24 20:49 ` [PATCH 09/11] mm/damon/sysfs: split out kdamond-independent schemes stats update logic into a new function SeongJae Park
2022-10-24 20:49 ` [PATCH 10/11] mm/damon/modules: deduplicate init steps for DAMON context setup SeongJae Park
2022-10-24 20:49 ` [PATCH 11/11] mm/damon/{reclaim,lru_sort}: remove unnecessarily included headers SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024204919.18524-4-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.