From: Rohan McLure <rmclure@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: Rohan McLure <rmclure@linux.ibm.com>
Subject: [PATCH] powerpc: Interrupt handler stack randomisation
Date: Tue, 25 Oct 2022 14:38:07 +1100 [thread overview]
Message-ID: <20221025033807.1413688-1-rmclure@linux.ibm.com> (raw)
Stack frames used by syscall handlers support random offsets as of
commit f4a0318f278d (powerpc: add support for syscall stack randomization).
Implement the same for general interrupt handlers, by applying the
random stack offset and then updating this offset from within the
DEFINE_INTERRUPT_HANDLER macros.
Applying this offset perturbs the layout of interrupt handler stack
frames, rendering to the kernel stack more difficult to control by means
of user invoked interrupts.
Link: https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-May/243238.html
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
---
arch/powerpc/include/asm/interrupt.h | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/powerpc/include/asm/interrupt.h b/arch/powerpc/include/asm/interrupt.h
index 4745bb9998bd..b7f7beff4e13 100644
--- a/arch/powerpc/include/asm/interrupt.h
+++ b/arch/powerpc/include/asm/interrupt.h
@@ -68,6 +68,7 @@
#include <linux/context_tracking.h>
#include <linux/hardirq.h>
+#include <linux/randomize_kstack.h>
#include <asm/cputime.h>
#include <asm/firmware.h>
#include <asm/ftrace.h>
@@ -448,9 +449,12 @@ interrupt_handler long func(struct pt_regs *regs) \
long ret; \
\
__hard_RI_enable(); \
+ add_random_kstack_offset(); \
\
ret = ____##func (regs); \
\
+ choose_random_kstack_offset(mftb()); \
+ \
return ret; \
} \
NOKPROBE_SYMBOL(func); \
@@ -480,9 +484,11 @@ static __always_inline void ____##func(struct pt_regs *regs); \
interrupt_handler void func(struct pt_regs *regs) \
{ \
interrupt_enter_prepare(regs); \
+ add_random_kstack_offset(); \
\
____##func (regs); \
\
+ choose_random_kstack_offset(mftb()); \
interrupt_exit_prepare(regs); \
} \
NOKPROBE_SYMBOL(func); \
@@ -515,9 +521,11 @@ interrupt_handler long func(struct pt_regs *regs) \
long ret; \
\
interrupt_enter_prepare(regs); \
+ add_random_kstack_offset(); \
\
ret = ____##func (regs); \
\
+ choose_random_kstack_offset(mftb()); \
interrupt_exit_prepare(regs); \
\
return ret; \
@@ -548,9 +556,11 @@ static __always_inline void ____##func(struct pt_regs *regs); \
interrupt_handler void func(struct pt_regs *regs) \
{ \
interrupt_async_enter_prepare(regs); \
+ add_random_kstack_offset(); \
\
____##func (regs); \
\
+ choose_random_kstack_offset(mftb()); \
interrupt_async_exit_prepare(regs); \
} \
NOKPROBE_SYMBOL(func); \
@@ -585,9 +595,11 @@ interrupt_handler long func(struct pt_regs *regs) \
long ret; \
\
interrupt_nmi_enter_prepare(regs, &state); \
+ add_random_kstack_offset(); \
\
ret = ____##func (regs); \
\
+ choose_random_kstack_offset(mftb()); \
interrupt_nmi_exit_prepare(regs, &state); \
\
return ret; \
--
2.34.1
next reply other threads:[~2022-10-25 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 3:38 Rohan McLure [this message]
2022-11-03 7:52 ` [PATCH] powerpc: Interrupt handler stack randomisation Christophe Leroy
2022-11-07 11:55 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025033807.1413688-1-rmclure@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.