From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1721C04A95 for ; Tue, 25 Oct 2022 12:38:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ADE0584DE6; Tue, 25 Oct 2022 14:38:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="N9i8mfhS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 11327806DE; Tue, 25 Oct 2022 14:38:00 +0200 (CEST) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6AF5280079 for ; Tue, 25 Oct 2022 14:36:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-io1-xd32.google.com with SMTP id 63so512745iov.8 for ; Tue, 25 Oct 2022 05:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+QBSrie/ttzsLPhNtzwMyesyWD+6EiLFs2nLXSr2Yik=; b=N9i8mfhS6JvMI0IzLOf6i3EfjkELv98nzxmeyaw1lk3MsHfM1rQmLMxl71/Z9yNd4D G7ldmjXd+mRseck9uxsseCrhQA9/HnwEBVopZ7XS3wf85JXXvwnbO1mYYMtOsFQ8RhBe d6R5MTauOMP+WgGETikE+gjHf8ZjAPqsgHUKk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+QBSrie/ttzsLPhNtzwMyesyWD+6EiLFs2nLXSr2Yik=; b=eFn201tmHdUZ24IlF7rcySslPPU3hdaJCFHorWdVrHOAA4bYUq49R2sypWzwDSM0aU D0NBNB3HxOPZU7gKSU2VRN14v2VltrOTfx7jcK4lrvOcm5JCN+qsJ8T8+qxCp4QB8AhJ APsrIXpyCnoinDsvZH5yERV1kuYvJ/JivE2OTtj/2IvHOoz19jWrJcsMkGtycMFVkbq1 roWIxvlH1HPSVm/lOQSe4smGBNGJddcd6zNx0nAX6w0pwZeiV/L0MBlyUAHalwirrOde rYMnddYVHQ8neRo59lay/IyE/ZUw1PhPYa2FvGiFxoU4pg7MIa03DGpgVLtm0QWKgDT6 26wA== X-Gm-Message-State: ACrzQf1cI56WlOD2E0POrqXB0ewbAwDlWYvKRV/LZllv00nmSjsDfhD8 wPZdj+YK+bqXVYLh56vzEXUJv9aui7+/uA== X-Google-Smtp-Source: AMsMyM6i5LxT2oYjvUIAZ/lS7fMiPxXQG+H13SESfLscpURsRRcgYRtTBMfWBrkkdc3LIVKyMqhaLw== X-Received: by 2002:a05:620a:400b:b0:6ee:e1f0:440f with SMTP id h11-20020a05620a400b00b006eee1f0440fmr26207406qko.558.1666700912913; Tue, 25 Oct 2022 05:28:32 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-6501-563e-adc8-d850.res6.spectrum.com. [2603:6081:7b00:6400:6501:563e:adc8:d850]) by smtp.gmail.com with ESMTPSA id x7-20020ac86b47000000b0039a372fbaa5sm1502273qts.69.2022.10.25.05.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 05:28:32 -0700 (PDT) Date: Tue, 25 Oct 2022 08:28:30 -0400 From: Tom Rini To: Stefano Babic Cc: Fabio Estevam , "NXP i.MX U-Boot Team" , Peng Fan , u-boot@lists.denx.de, Oliver Graute Subject: Re: [PATCH v3] imx: imx8qm: cgtqmx8: switch to binman Message-ID: <20221025122830.GJ2020586@bill-the-cat> References: <20220503104819.24694-1-oliver.graute@kococonnector.com> <1074825c-ac02-8cc8-604d-bd465cdd40d8@denx.de> <20221024115914.GA19855@optiplex> <20221025085018.GB19855@optiplex> <4bfa6e49-4e2d-0b04-355f-19ed058bef7e@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="04FybxbhfaAKXQYm" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --04FybxbhfaAKXQYm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 25, 2022 at 02:07:55PM +0200, Stefano Babic wrote: > On 25.10.22 11:28, Stefano Babic wrote: > > On 25.10.22 10:50, Oliver Graute wrote: > > > On 24/10/22, Stefano Babic wrote: > > > > On 24.10.22 13:59, Oliver Graute wrote: > > > > > On 24/10/22, Stefano Babic wrote: > > > > > > On 24.10.22 13:37, Fabio Estevam wrote: > > > > > > > Hi Stefano and Oliver, > > > > > > >=20 > > > > > > > On Tue, May 3, 2022 at 7:49 AM Oliver Graute > > > > > > > wrote: > > > > > > > >=20 > > > > > > > > Switch to use binman to pack images > > > > > > > >=20 > > > > > > > > Signed-off-by: Oliver Graute > > > > > > > > Reviewed-by: Fabio Estevam > > > > > > > > Reviewed-by: Simon Glass > > > > > > > > --- > > > > > > > > Changes for v3 > > > > > > > > =A0=A0=A0 -added Reviewed-by > > > > > > > > =A0=A0=A0 -rebased on master > > > > > > > >=20 > > > > > > > > =A0=A0=A0 arch/arm/dts/imx8qm-cgtqmx8.dts=A0=A0=A0=A0 | 1 + > > > > > > > > =A0=A0=A0 arch/arm/mach-imx/imx8/Kconfig=A0=A0=A0=A0=A0 | 1= + > > > > > > > > =A0=A0=A0 board/congatec/cgtqmx8/imximage.cfg | 4 ++-- > > > > > > > > =A0=A0=A0 configs/cgtqmx8_defconfig=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 | 2 +- > > > > > > > > =A0=A0=A0 doc/board/congatec/cgtqmx8.rst=A0=A0=A0=A0=A0 | 3= +-- > > > > > > > > =A0=A0=A0 5 files changed, 6 insertions(+), 5 deletions(-) > > > > > > >=20 > > > > > > > Just realized that v3 does not include > > > > > > > imx8qm-u-boot.dtsi and this breaks CI. > > > > > > >=20 > > > > > >=20 > > > > > > Right - as well as V4, this is what I tried to merge and > > > > > > breaks. I have drop > > > > > > it. > > > > > >=20 > > > > > > > The previous v2 did include it: > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/202202210901= 39.10066-1-oliver.graute@kococonnector.com/ > > > > > >=20 > > > > > > Thanks for noting this - Oliver, can you check and repost a V5,= then ? > > > > >=20 > > > > > The arch/arm/dts/imx8qm-u-boot.dtsi=A0 is applied on the binman P= atch for > > > > > "PATCH v3 imx: imx8qm-rom7720: switch to binman" > > > > >=20 > > > > > So if you first apply the patches for the imx8qm-rom7720 > > > > > Board it should work. > > > >=20 > > > >=20 > > > > Ok, thanks for tipp - I apply both and will test again > > >=20 > > > I saw the CI Pipeline failing. Perhaps the reason is a > > > missing CONFIG_FIT_EXTERNAL_OFFSET? > > >=20 > >=20 > > I see this, but just applying the two patches, multiple boards are brok= en: > > imx8qm_rom7720_a1_4G cgtqmx8 imx8qm_mek imx8qxp_mek deneb giedi > >=20 > >=20 > > > +++ b/configs/cgtqmx8_defconfig > > > @@ -20,6 +20,7 @@ CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=3Dy > > > =A0 CONFIG_CUSTOM_SYS_INIT_SP_ADDR=3D0x80200000 > > > =A0 CONFIG_REMAKE_ELF=3Dy > > > =A0 CONFIG_FIT=3Dy > > > +CONFIG_FIT_EXTERNAL_OFFSET=3D0x3000 > > > =A0 CONFIG_SPL_LOAD_FIT=3Dy > > > =A0 # CONFIG_USE_SPL_FIT_GENERATOR is not set > > >=20 > > > Can you confirm? > > >=20 > >=20 > > I let CI run just to see if cgtqmx8 is fixed. >=20 > So this seems to fix the Congatec board. Rather, all DTS for i.MX8 are bu= ilt > together, and other boards have not switched to binman. I feel this > dependency too hard. Should we maybe split the targets in > arch/arm/dts/Makefile ? All DTS are build according to CONFIG_ARCH_IMX8, = so > congatec DTS is compiled even in case of deneb and gied. >=20 > See https://source.denx.de/u-boot/custodians/u-boot-imx/-/pipelines/13928. IMHO at this point we need to just untested-convert those last outstanding board or boards, or remove them. This migration has been dragging on and on and I'm sure I've mailed the board maintainers a few times. --=20 Tom --04FybxbhfaAKXQYm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNX1moACgkQFHw5/5Y0 tyxKhgv8DkHt0fQKUrByMx1IQBBka7pHmTigZvIPuCxKaGnHCZOcJ9dEiSWWsK7L BTU86ErwK38TrcuzYmgJgI3zu4x+KR7P5/HW/JSDmtw6L7dld/aZlolHQnH/xeDh CyvauWklytlJEVTKGyfn5YwZCS2NqdUxRIZBInp+ogoZzsq7Dc8770Xl/Ybmche8 7Qs6HusouRg4C4XtUGrn9ZYjVZXpdJ1lZ0AC6yaPZ16itVo2ZYy85dPzMpgb0pln a2mGd4bp+5s2QCZdaW6Z6Jm1DZTcE6863ZUdSJyQeE3X+A/BVOZWGKxwEcD35CAI nro9mT0p9NhDZuvxFmrFKciXBCYo2xRHsbZRsNoAbpgQEh6w20vcAYdMysqjtbh7 kA+1TO2OacTcCiVySUaI8WiimgmeBND9iY0Rm0fpIfEkansEfkdzL1+JOjcH/M2G WXPhKpi7dOmaNcPPAJvtoosAIn4hyNSo11x2mqyhY3RuDXcTLmpnKY5gWzY/eO9c KuIICTU+ =kWye -----END PGP SIGNATURE----- --04FybxbhfaAKXQYm--