All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Graute <oliver.graute@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: trini@konsulko.com, sbabic@denx.de, uboot-imx@nxp.com,
	peng.fan@nxp.com, u-boot@lists.denx.de,
	"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
	"Ye Li" <ye.li@nxp.com>, "Gaurav Jain" <gaurav.jain@nxp.com>,
	"Denys Drozdov" <denys.drozdov@toradex.com>,
	"Horia Geantă" <horia.geanta@nxp.com>
Subject: Re: [PATCH v3] imx: imx8qm-rom7720: switch to binman
Date: Tue, 25 Oct 2022 16:26:09 +0200	[thread overview]
Message-ID: <20221025142609.GD19855@optiplex> (raw)
In-Reply-To: <CAOMZO5A+zSQJvQTuv=YgNZOdZt_baffx1qUdUYovWCWf86rZWA@mail.gmail.com>

On 25/10/22, Fabio Estevam wrote:
> Hi Oliver,
> 
> On Fri, Oct 7, 2022 at 10:14 AM Oliver Graute
> <oliver.graute@kococonnector.com> wrote:
> 
> > +                               fdt {
> > +                                       filename = "imx8qm-rom7720-a1";
> 
> Please do not hardcode this dtb filename inside the common
> imx8qm-u-boot.dtsi file.

OK I'll remove the line
> 
> You can look at arch/arm/dts/imx8mm-u-boot.dtsi  as a reference.

OK

> 
> > +                                       type = "flat_dt";
> > +                                       compression = "none";
> > +
> > +                                       uboot_fdt_blob {
> > +                                               filename = "u-boot.dtb";
> > +                                               type = "blob-ext";
> > +                                       };
> > +                               };
> > +                       };
> > +
> > +                       configurations {
> > +                               default = "conf";
> > +
> > +                               conf {
> > +                                       filename = "imx8qm-rom7720-a1";
> 
> Same here.

Ok

> 
> Also, could you please try converting all imx8mq/qxp boards to binman?

ok I'll try this. 

> Thanks

Best regards,

Oliver

      reply	other threads:[~2022-10-25 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 13:09 [PATCH v3] imx: imx8qm-rom7720: switch to binman Oliver Graute
2022-10-25 14:04 ` Fabio Estevam
2022-10-25 14:26   ` Oliver Graute [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221025142609.GD19855@optiplex \
    --to=oliver.graute@gmail.com \
    --cc=denys.drozdov@toradex.com \
    --cc=festevam@gmail.com \
    --cc=gaurav.jain@nxp.com \
    --cc=horia.geanta@nxp.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=peng.fan@nxp.com \
    --cc=sbabic@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    --cc=ye.li@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.