From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Martin Bark <martin@barkynet.com>,
Daniel Price <daniel.price@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper
Date: Tue, 25 Oct 2022 22:57:05 +0200 [thread overview]
Message-ID: <20221025225705.31a1975c@windsurf> (raw)
In-Reply-To: <20221025190236.1190494-1-james.hilliard1@gmail.com>
On Tue, 25 Oct 2022 13:02:36 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> The configure file is a shell script which searches for a predefined
> python binary and then calls configure.py with that.
>
> As we already call configure with the desired python binary we should
> call configure.py directly so that the expected python binary is used
> and so that the shell wrapper doesn't throw spurious interpreter
> validation errors.
>
> This also avoid spurious errors due to the configure shell wrapper
> missing supported python versions, for example this fixes:
> Node.js configure: Found Python 3.11.0...
> Please use python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
> /usr/bin/python3.10 ./configure
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/nodejs/nodejs.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-25 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 19:02 [Buildroot] [PATCH 1/1] package/nodejs: bypass configure shell wrapper James Hilliard
2022-10-25 20:57 ` Thomas Petazzoni via buildroot [this message]
2022-11-05 10:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025225705.31a1975c@windsurf \
--to=buildroot@buildroot.org \
--cc=daniel.price@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=martin@barkynet.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.