All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shnelson@amd.com>
Cc: Shannon Nelson <snelson@pensando.io>,
	davem@davemloft.net, netdev@vger.kernel.org, leon@kernel.org,
	drivers@pensando.io
Subject: Re: [PATCH v2 net-next 3/5] ionic: new ionic device identity level and VF start control
Date: Wed, 26 Oct 2022 09:31:01 -0700	[thread overview]
Message-ID: <20221026093101.67fe65ed@kernel.org> (raw)
In-Reply-To: <2b469008-4057-cbe0-8640-73d42490f65e@amd.com>

On Tue, 25 Oct 2022 21:23:53 -0700 Shannon Nelson wrote:
> These additions are matching the style that is already in the file, 
> which I think has some merit.  Sure, I'll fix these specific kdoc 
> complaints, but those few bits are going to look weirdly out-of-place 
> with the rest of the file.

Gotta start somewhere...

> I see that kdoc is unhappy with that whole file, but I wasn't prepared 
> today to be tweaking the rest of the file to make kdoc happy.  That is 
> now on my list of near-future To-Do items.

Yeah, no need to do a whole-sale fix in this series, let's just prevent
new problems from coming in.

> Just curious - when was the kdoc check added to the netdev submission 
> checks?  Have I just been missing it in the past?

I was wondering as well, our check is pretty old, perhaps the behavior
of ./scripts/kernel-doc changed or we just weren't as strict in
enforcing this as maintainers?  Kdoc mis-formatting happens
sufficiently infrequently to make enforcing "no new warnings" feasible.
I think mostly due to W=1 catching the issues in source files,
so people notice right away. Unfortunately it doesn't check headers.

  reply	other threads:[~2022-10-26 16:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-25 11:24 [PATCH v2 net-next 0/5] ionic: VF attr replay and other updates Shannon Nelson
2022-10-25 11:24 ` [PATCH v2 net-next 1/5] ionic: replay VF attributes after fw crash recovery Shannon Nelson
2022-10-25 11:24 ` [PATCH v2 net-next 2/5] ionic: only save the user set VF attributes Shannon Nelson
2022-10-25 11:24 ` [PATCH v2 net-next 3/5] ionic: new ionic device identity level and VF start control Shannon Nelson
2022-10-26  3:08   ` Jakub Kicinski
2022-10-26  4:23     ` Shannon Nelson
2022-10-26 16:31       ` Jakub Kicinski [this message]
2022-10-25 11:24 ` [PATCH v2 net-next 4/5] ionic: enable tunnel offloads Shannon Nelson
2022-10-25 11:24 ` [PATCH v2 net-next 5/5] ionic: refactor use of ionic_rx_fill() Shannon Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221026093101.67fe65ed@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=drivers@pensando.io \
    --cc=leon@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shnelson@amd.com \
    --cc=snelson@pensando.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.