From: Jakub Kicinski <kuba@kernel.org>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>, <jiri@mellanox.com>,
<weiyongjun1@huawei.com>, <yuehaibing@huawei.com>
Subject: Re: [PATCH net] netdevsim: fix memory leak in nsim_bus_dev_new()
Date: Wed, 26 Oct 2022 20:35:52 -0700 [thread overview]
Message-ID: <20221026203552.7eaf37cf@kernel.org> (raw)
In-Reply-To: <20221026015405.128795-1-shaozhengchao@huawei.com>
On Wed, 26 Oct 2022 09:54:05 +0800 Zhengchao Shao wrote:
> If device_register() failed in nsim_bus_dev_new(), the value of reference
> in nsim_bus_dev->dev is 1. obj->name in nsim_bus_dev->dev will not be
> released.
The fixes tag is still not 100% but I guess the bug was
slightly different before and after that patch, so:
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2022-10-27 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 1:54 [PATCH net] netdevsim: fix memory leak in nsim_bus_dev_new() Zhengchao Shao
2022-10-27 3:35 ` Jakub Kicinski [this message]
2022-10-27 18:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026203552.7eaf37cf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.