From: Jakub Kicinski <kuba@kernel.org>
To: "zhaoping.shu" <zhaoping.shu@mediatek.com>,
John 'Warthog9' Hawley <warthog9@kernel.org>
Cc: <m.chetan.kumar@intel.com>, <linuxwwan@intel.com>,
<loic.poulain@linaro.org>, <ryazanov.s.a@gmail.com>,
<johannes@sipsolutions.net>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<srv_heupstream@mediatek.com>, <haijun.liu@mediatek.com>,
<xiayu.zhang@mediatek.com>, <lambert.wang@mediatek.com>,
"hw . he" <hw.he@mediatek.com>
Subject: Re: [PATCH net v2] net: wwan: iosm: fix memory leak in ipc_wwan_dellink
Date: Thu, 27 Oct 2022 10:46:08 -0700 [thread overview]
Message-ID: <20221027104608.246aa30c@kernel.org> (raw)
In-Reply-To: <20221027070206.107333-1-zhaoping.shu@mediatek.com>
On Thu, 27 Oct 2022 15:02:06 +0800 zhaoping.shu wrote:
> From: hw.he <hw.he@mediatek.com>
>
> IOSM driver registers network device without setting the
> needs_free_netdev flag, and does NOT call free_netdev() when
> unregisters network device, which causes a memory leak.
>
> This patch sets needs_free_netdev to true when registers
> network device, which makes netdev subsystem call free_netdev()
> automatically after unregister_netdevice().
>
> Fixes: 2a54f2c77934 ("net: iosm: net driver")
> Signed-off-by: hw.he <hw.he@mediatek.com>
> Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: zhaoping.shu <zhaoping.shu@mediatek.com>
Annoyingly the patches are still not making it to the list.
John, any hints you can gather from vger's logs? The patches
were resent 3 times with a 0 success rate.
Last time we hit this was with Gmail, but it doesn't seem like
mediatek.com is using Google Mail?
parent reply other threads:[~2022-10-27 17:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221027070206.107333-1-zhaoping.shu@mediatek.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027104608.246aa30c@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=hw.he@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=lambert.wang@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=warthog9@kernel.org \
--cc=xiayu.zhang@mediatek.com \
--cc=zhaoping.shu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.