All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Felix Kuehling <felix.kuehling@amd.com>
Cc: mm-commits@vger.kernel.org, Xinhui.Pan@amd.com,
	willy@infradead.org, lyude@redhat.com, kherbst@redhat.com,
	jhubbard@nvidia.com, jglisse@redhat.com, jgg@nvidia.com,
	jack@suse.cz, hch@lst.de, djwong@kernel.org, daniel@ffwll.ch,
	christian.koenig@amd.com, bskeggs@redhat.com, apopple@nvidia.com,
	alexander.deucher@amd.com, airlied@linux.ie,
	dan.j.williams@intel.com, Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: + mm-memremap-introduce-pgmap_request_folio-using-pgmap-offsets.patch added to mm-unstable branch
Date: Thu, 27 Oct 2022 11:56:32 -0700	[thread overview]
Message-ID: <20221027115632.aa8bd33027ecea77a30f7674@linux-foundation.org> (raw)
In-Reply-To: <3a35bcc0-71df-c302-081d-990c5e5ed096@amd.com>

On Wed, 26 Oct 2022 16:23:22 -0400 Felix Kuehling <felix.kuehling@amd.com> wrote:

> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c~mm-memremap-introduce-pgmap_request_folio-using-pgmap-offsets
> > +++ a/drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
> [snip]
> > @@ -325,7 +328,8 @@ svm_migrate_copy_to_vram(struct amdgpu_d
> >   
> >   		dst[i] = cursor.start + (j << PAGE_SHIFT);
> >   		migrate->dst[i] = svm_migrate_addr_to_pfn(adev, dst[i]);
> > -		svm_migrate_get_vram_page(prange, migrate->dst[i]);
> > +			svm_migrate_get_vram_page(&kfddev->pgmap, prange,
> > +						  migrate->dst[i]);
> 
> Yang Lee pointed out that the indentation was broken here. I don't know 
> what to do with his patch because it doesn't apply to the branches I 
> work on. What's the best way to fix this before it goes to Linus' master 
> branch?

Thanks, I added a fixup patch.

      parent reply	other threads:[~2022-10-27 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 19:26 + mm-memremap-introduce-pgmap_request_folio-using-pgmap-offsets.patch added to mm-unstable branch Andrew Morton
2022-10-26 20:23 ` Felix Kuehling
2022-10-26 20:32   ` Dan Williams
2022-10-26 20:45     ` Felix Kuehling
2022-10-27 18:56   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221027115632.aa8bd33027ecea77a30f7674@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=apopple@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=djwong@kernel.org \
    --cc=felix.kuehling@amd.com \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=jgg@nvidia.com \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=kherbst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=mm-commits@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=yang.lee@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.