From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57013FA3740 for ; Thu, 27 Oct 2022 13:02:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DEFB385075; Thu, 27 Oct 2022 15:02:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fuGKc6Ly"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E4BF585076; Thu, 27 Oct 2022 15:02:29 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D456684D78 for ; Thu, 27 Oct 2022 15:02:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id t25so788207qkm.2 for ; Thu, 27 Oct 2022 06:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gmQB/PB46ovNe9ZJOThaHxz20XXliH9OH5k4EgzmE8U=; b=fuGKc6LyImnehJ1bWWGbg7crqwyMbzK68ENtG8E7/cN7SmCr+484fkJXggVzV66kSY s6v+dKViv8RJ8b4eQdgAbLYcJQx740ko2NWebEQC/eYLa1FGFfd7KqOBbEK/SUhDi57h svmrWcWVEZdbUQ2ImC4TABCTjNPd1M84qusTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gmQB/PB46ovNe9ZJOThaHxz20XXliH9OH5k4EgzmE8U=; b=kg0tn+4WjZiZLrMuVp0NgCL2Dvmely5HseYpFWPJGvImma0jt2JQsx634OITk2kAmZ z5QY90ESlTR5YHl7h+iluGkJXIiUr+nh+Lyx/jI97i7WUqOH0VU0aqWLVZ6wC5VmR2p4 SXH/rgaZUJQvNd6chJ2ZeKX6wKI+vpFK731j/mqVYGkVcvEsdH5l1r+3WuN2IE4uPcWI mzLTYeP3+02kSv9AtHl+My/PTo7kU3UvmT9BmDA7VhI6HHpn0luJSJdNO59klLckUhWM 0TCXXgcKsw9ViRjIQPC0Bp92QA1Jv2qPVQi2FLpIPSYpVdKJvYbeCIZB1rClnDBOvdAW Cm7A== X-Gm-Message-State: ACrzQf0M1HqWNjIcoKymviUTiS36GzMAPqwlyW2OheoEQqXb9bz8Rsqu I7BZfIFk1n4LVB1qcBLe1wB0ZA== X-Google-Smtp-Source: AMsMyM7I9gJvzSYhNn8iyjf8DOPnQxNAyjJgP+fMpH8JNkaBYNTjLmCUyQ0Ipll3xsc9ezkNHpu3wQ== X-Received: by 2002:a37:584:0:b0:6eb:b98:926b with SMTP id 126-20020a370584000000b006eb0b98926bmr34357871qkf.233.1666875745546; Thu, 27 Oct 2022 06:02:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-f430-99ec-b6f9-cbc9.res6.spectrum.com. [2603:6081:7b00:6400:f430:99ec:b6f9:cbc9]) by smtp.gmail.com with ESMTPSA id f17-20020ac84651000000b003436103df40sm866228qto.8.2022.10.27.06.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:02:25 -0700 (PDT) Date: Thu, 27 Oct 2022 09:02:23 -0400 From: Tom Rini To: Sinthu Raja Cc: u-boot@lists.denx.de, Simon Glass , Marcel Ziswiler , Marek Vasut , Vignesh Raghavendra , Sinthu Raja Subject: Re: [PATCH 06/11] board: ti: j721s2: Add support for detecting multiple device trees Message-ID: <20221027130223.GJ2020586@bill-the-cat> References: <20221027104846.11820-1-sinthu.raja@ti.com> <20221027104846.11820-7-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hv/2fCdzBANChyxq" Content-Disposition: inline In-Reply-To: <20221027104846.11820-7-sinthu.raja@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --Hv/2fCdzBANChyxq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 04:18:41PM +0530, Sinthu Raja wrote: > From: Sinthu Raja >=20 > Update the board_fit_config_name_match() to choose the right dtb > based on the board name read from EEPROM. >=20 > Also restrict multpile EEPROM reads by verifying if EEPROM is already > read >=20 > Signed-off-by: Sinthu Raja > --- > board/ti/j721s2/evm.c | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/board/ti/j721s2/evm.c b/board/ti/j721s2/evm.c > index 8ada924e3f..25667900ce 100644 > --- a/board/ti/j721s2/evm.c > +++ b/board/ti/j721s2/evm.c > @@ -79,8 +79,17 @@ int dram_init_banksize(void) > #ifdef CONFIG_SPL_LOAD_FIT > int board_fit_config_name_match(const char *name) > { > - if (!strcmp(name, "k3-j721s2-common-proc-board")) > - return 0; > + bool eeprom_read =3D board_ti_was_eeprom_read(); > + > + if (!eeprom_read || board_is_j721s2_som()) { > + if (!strcmp(name, "k3-j721s2-common-proc-board") || > + !strcmp(name, "k3-j721s2-r5-common-proc-board")) > + return 0; > + } else if (!eeprom_read || board_is_am68_sk_som()) { > + if (!strcmp(name, "k3-am68-sk-base-board") || > + !strcmp(name, "k3-am68-sk-r5-base-board")) > + return 0; > + } > =20 > return -1; > } Do we actually need a different DTB to be used in SPL, in order to get the right DTB for full U-Boot? It's an intentional design decision here that we go board-specific as late as possible, so that it's clearer for custom designs what they do and do not need to modify. --=20 Tom --Hv/2fCdzBANChyxq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNagV8ACgkQFHw5/5Y0 tyzm8gv/UqX173NlYhsXQcBgzVCTYLhwcq+Ce9D5+VIpbHNP7jDInooi0Gz0/G99 FW/Fqfh3FgyEQlYdPA+7tXS7RZKyzku3n5AEeLHId+l/DUXpm4HCNRvA4EEdXcWR Inwd4CTwWmKH9qAUQtDThKbZz7hWZOZ5WnOw1zI3rAA4cAWJNbWnMLvKSADbgH4S trXts6jffYw/C3y76Lfewn4LQqAwSsFpCBC4hq5DEvxaJzZHd0/tfWKXcl1jbOXA Hue5HNiuaaF6gkv8AjICsyAJYGSzQmCESKaEMt0zs1kLoyn10+V2xb61uI4te7us 7DgUs73CnCjVNiHvThZUnASQBU6AVibSxUy/X7caean2Wa8DARQWgl3Orii2OCLj fboPqoe2mPzC9sBNqZJ5jnGR3VlxZZkvIsua0Z5adoUMJPm936J4i4oPrGcz0q0x 6CTLjOtyDxK7Vx2LRr+xhvyA7Lnak36onI4icP0vGRU8SE7XtXk8M/iXoEfGrJxD TViv7aXY =3z0W -----END PGP SIGNATURE----- --Hv/2fCdzBANChyxq--