From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>,
Johannes Berg <johannes@sipsolutions.net>
Cc: <netdev@vger.kernel.org>,
netfilter-devel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next 1/2] netlink: introduce NLA_POLICY_MAX_BE
Date: Thu, 27 Oct 2022 13:31:09 -0700 [thread overview]
Message-ID: <20221027133109.590bd74f@kernel.org> (raw)
In-Reply-To: <20220905100937.11459-2-fw@strlen.de>
On Mon, 5 Sep 2022 12:09:36 +0200 Florian Westphal wrote:
> struct {
> s16 min, max;
> + u8 network_byte_order:1;
> };
This makes the union 64bit even on 32bit systems.
Do we care? Should we accept that and start using
full 64bits in other validation members?
We can quite easily steal a bit elsewhere, which
I reckon may be the right thing to do, but I thought
I'd ask.
next prev parent reply other threads:[~2022-10-27 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 10:09 [PATCH net-next 0/2] netlink: add range checks for network byte integers Florian Westphal
2022-09-05 10:09 ` [PATCH net-next 1/2] netlink: introduce NLA_POLICY_MAX_BE Florian Westphal
2022-10-27 20:31 ` Jakub Kicinski [this message]
2022-10-27 20:36 ` Johannes Berg
2022-10-27 23:35 ` Florian Westphal
2022-10-28 2:39 ` Jakub Kicinski
2022-10-28 10:16 ` Florian Westphal
2022-10-28 16:13 ` Jakub Kicinski
2022-09-05 10:09 ` [PATCH net-next 2/2] netfilter: nft_payload: reject out-of-range attributes via policy Florian Westphal
2022-09-07 11:40 ` [PATCH net-next 0/2] netlink: add range checks for network byte integers patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027133109.590bd74f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.