From: Vladimir Oltean <olteanv@gmail.com>
To: Camel Guo <camel.guo@axis.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Vivien Didelot <vivien.didelot@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Rob Herring <robh@kernel.org>,
kernel@axis.com
Subject: Re: [RFC net-next 1/2] dt-bindings: net: dsa: add bindings for GSW Series switches
Date: Thu, 27 Oct 2022 18:41:56 +0300 [thread overview]
Message-ID: <20221027154156.wdi2ka52xwdgm7cj@skbuf> (raw)
In-Reply-To: <20221025135243.4038706-2-camel.guo@axis.com>
Hi Camel,
On Tue, Oct 25, 2022 at 03:52:40PM +0200, Camel Guo wrote:
> +additionalProperties: true
I don't think the switch schema should have additionalProperties: true.
Only shared schemas should. WHat should be here is "unevaluatedProperties: false".
> + port@5 {
> + reg = <5>;
> + label = "cpu";
Please drop label = "cpu" for the CPU port, it is not needed/not parsed.
> + ethernet = <ð0>;
> + phy-mode = "rgmii-id";
> +
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + pause;
> + };
> + };
> + };
next prev parent reply other threads:[~2022-10-27 15:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 13:52 [RFC net-next 0/2] DSA driver draft for MaxLinear's gsw1xx series switch Camel Guo
2022-10-25 13:52 ` [RFC net-next 1/2] dt-bindings: net: dsa: add bindings for GSW Series switches Camel Guo
2022-10-25 14:27 ` Krzysztof Kozlowski
2022-10-25 15:01 ` Andrew Lunn
2022-10-25 19:00 ` Krzysztof Kozlowski
[not found] ` <d0179725-0730-5826-caa4-228469d3bad4@axis.com>
2022-10-27 12:46 ` Krzysztof Kozlowski
2022-10-27 13:57 ` Vladimir Oltean
2022-10-27 16:08 ` Krzysztof Kozlowski
2022-10-27 16:12 ` Vladimir Oltean
2022-10-25 20:05 ` Rob Herring
2022-10-27 15:41 ` Vladimir Oltean [this message]
2022-10-25 13:52 ` [RFC net-next 2/2] net: dsa: Add driver for Maxlinear GSW1XX switch Camel Guo
2022-10-25 14:23 ` Krzysztof Kozlowski
2022-10-25 14:56 ` Andrew Lunn
2022-10-27 6:35 ` Camel Guo
2022-10-27 12:09 ` Andrew Lunn
[not found] ` <55da4718-4422-745a-8880-95adc8e0abd9@axis.com>
2022-10-27 12:48 ` Krzysztof Kozlowski
2022-10-25 14:53 ` Andrew Lunn
[not found] ` <a04fc8bd-e18e-c300-8300-7cba8fe33557@axis.com>
2022-10-27 12:20 ` Andrew Lunn
2022-10-27 16:00 ` Vladimir Oltean
2022-10-28 4:41 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027154156.wdi2ka52xwdgm7cj@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=camel.guo@axis.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.