From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B46A7FA3742 for ; Thu, 27 Oct 2022 18:31:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D50685074; Thu, 27 Oct 2022 20:30:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="M5n2bk4Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9631D8506F; Thu, 27 Oct 2022 20:30:57 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3EDE585074 for ; Thu, 27 Oct 2022 20:30:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf36.google.com with SMTP id c8so2132937qvn.10 for ; Thu, 27 Oct 2022 11:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=tZ0w2XAKl+hefNMLT97ZD7mR4V4uYB0zBq5bGqnVtP8=; b=M5n2bk4ZZQu1Z4CmhiqA9YZF6gHLFBrDD+W9quMlj/4CJRrcvSBX+pjAAQZgPKI83C ulFSGH/QcL9v0c25xLlQevTL9lW/p9T0KzUOuT6cfTphStJmqJVFSkRhXH8FB6nwyMWF E3WsPCH2aqNsGhgGf4Xx/8qa9WJS5G/2ZEvwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tZ0w2XAKl+hefNMLT97ZD7mR4V4uYB0zBq5bGqnVtP8=; b=pugYHDhjcuO9h89P6DGDlLDsk/qDNx5qOVUrULN/4Bo5LUPNjHjv+YbAFonlHGkel7 m9JG59a70uuHypvn9fmM6x1TQ/6Y6yOofNFbS9imPjtID/5CL+g7l6vZb6wa7H+vZvPp 3WTEIQUly+tNd+MZdVxR/TEdLOU/1FcLcdnPtd02VV9N0VRQsqOCzJ/ylTMsWFB4SiLZ NAnd5g7HSErE3xLqC43ZQbE6f/x2JgSW/sX48ZKYIH0QLwt8pJedm8MG1R1UPicql1oU vezetsjYZvH73UnFDgNKttEIy5j/i5jF7m2PXMSA84Qe1747gbSoPZlcxX+Jwq5RZHRB QMPw== X-Gm-Message-State: ACrzQf2KTT37DOs4N9YVktOAguKTjNbA/NG8lUlbcb9NYaCOoIT6G2dM +kncOX1GYX+5NGhbjRX6BaIi8A== X-Google-Smtp-Source: AMsMyM5kljSwYf00eylLnwqClCB0zqzPX1KzBzWhqKWa2e/OCbkQ2H9LQ2uYOGAS1OncrnKGwazxog== X-Received: by 2002:a05:6214:258f:b0:4bb:96dc:9081 with SMTP id fq15-20020a056214258f00b004bb96dc9081mr7618427qvb.56.1666895453883; Thu, 27 Oct 2022 11:30:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-f430-99ec-b6f9-cbc9.res6.spectrum.com. [2603:6081:7b00:6400:f430:99ec:b6f9:cbc9]) by smtp.gmail.com with ESMTPSA id t6-20020ac85306000000b00398df095cf5sm1237174qtn.34.2022.10.27.11.30.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 11:30:53 -0700 (PDT) Date: Thu, 27 Oct 2022 14:30:51 -0400 From: Tom Rini To: Detlev Casanova Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Message-ID: <20221027183051.GN2020586@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ACytTbRcHu0RrWk1" Content-Disposition: inline In-Reply-To: <20221027152252.46552-1-detlev.casanova@collabora.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --ACytTbRcHu0RrWk1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote: > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree was > synchronized from linux and the aliases were dropped. >=20 > They need to be kept so that the mmc cards are in the right order. > Without the aliases, u-boot reports: > MMC: FSL_SDHC: 2, FSL_SDHC: 3 >=20 > With the aliases, u-boot reports: > MMC: FSL_SDHC: 0, FSL_SDHC: 1 >=20 > Signed-off-by: Detlev Casanova > --- > arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi b/arch/arm/dts/imx6qdl-s= abrelite.dtsi > index 22f8e2783c..6564e3b82c 100644 > --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi > +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi > @@ -10,6 +10,13 @@ > #include > =20 > / { > + aliases { > + mmc0 =3D &usdhc3; > + mmc1 =3D &usdhc4; > + pwm_lcd =3D &pwm1; > + pwm_lvds =3D &pwm4; > + }; > + > chosen { > stdout-path =3D &uart2; > }; This really belongs in the upstream dts file so they aren't lost again and again. --=20 Tom --ACytTbRcHu0RrWk1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmNazlcACgkQFHw5/5Y0 tywhiwv9Hu4UJiEhGSAfn01goAwT4jsd3H7svMDh9SRQxaTEgL0ZxcmXxc/q1F0F I4TJtMld5tA+HZX3n/aSbErQBtA3oDbVDfOuezLT5U85QuL+1VTr/Oscsi2AYxDo 5Mi8fk6S+r1e/mQ0DBMrnsNZ6ClYazBPLJdb2DE909lrnoHZny6/bBw6KMnXw3Oi zfz6turZjEzpJVnOc9d8JzZaceULYkV2J/Bd5RpFpr0g+iw585GS/yTxop1jS1XU 0RFwswdcy7kqsrQb0wRoG2KCl6ldegNNqUh5JXzkFCRBxfkpWR8s7FvYeQ1webiw CapkUFmQvbYdNy3YfhlFjko/MCj6nNgt766OCnPGhwUUuvzmqd6Qs9mrUZjy7mNM euPTS2NYj3g0JfZBN/MJqzz9sV+iXQpp3GP8msDC9I9KlOsmJA9kuopzNL+VzkK8 QxhsTE8x8MYWeYDhj45hiA/0FeJOQrTmi140wBEVv2d9pG1Zl3bGtpKGwjJ8/5me TK/s3FWE =oSqd -----END PGP SIGNATURE----- --ACytTbRcHu0RrWk1--