From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, corbet@lwn.net, michael.chan@broadcom.com,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
huangguangbin2@huawei.com, chenhao288@hisilicon.com,
moshet@nvidia.com, linux@rempel-privat.de,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v2] ethtool: linkstate: add a statistic for PHY down events
Date: Thu, 27 Oct 2022 20:08:49 -0700 [thread overview]
Message-ID: <20221027200849.34e26e3e@kernel.org> (raw)
In-Reply-To: <880ede37-773e-c2bd-8a69-6e3d202983d9@gmail.com>
On Thu, 27 Oct 2022 19:50:35 -0700 Florian Fainelli wrote:
> > @@ -723,6 +724,8 @@ struct phy_device {
> >
> > int pma_extable;
> >
> > + unsigned int link_down_events;
>
> Should not this be an u64 to match what the extended link state can
> report? Not that I would hope that anyone had a chance to witness 4
> billion link down events using PHYLIB.
How about I also make the uAPI side 32 bit? I made it 64b because
that feels like the default these days but as you say, re-training
a link 4 billion times is unlikely to happen in one person's lifetime :S
next prev parent reply other threads:[~2022-10-28 3:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 1:27 [PATCH net-next v2] ethtool: linkstate: add a statistic for PHY down events Jakub Kicinski
2022-10-28 2:50 ` Florian Fainelli
2022-10-28 3:08 ` Jakub Kicinski [this message]
2022-10-28 12:18 ` Andrew Lunn
2022-10-28 16:20 ` Jakub Kicinski
2022-10-28 22:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027200849.34e26e3e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=huangguangbin2@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=michael.chan@broadcom.com \
--cc=moshet@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.