From: Jakub Kicinski <kuba@kernel.org>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: netdev@vger.kernel.org, alexandr.lobakin@intel.com,
jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
ecree.xilinx@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net-next v7 5/9] devlink: Allow to set up parent in devl_rate_leaf_create()
Date: Thu, 27 Oct 2022 20:28:27 -0700 [thread overview]
Message-ID: <20221027202827.701a9a68@kernel.org> (raw)
In-Reply-To: <20221027130049.2418531-6-michal.wilczynski@intel.com>
On Thu, 27 Oct 2022 15:00:45 +0200 Michal Wilczynski wrote:
> @@ -10327,10 +10327,11 @@ EXPORT_SYMBOL_GPL(devl_rate_node_create);
> *
> * Create devlink rate object of type leaf on provided @devlink_port.
> */
> -int devl_rate_leaf_create(struct devlink_port *devlink_port, void *priv)
> +int devl_rate_leaf_create(struct devlink_port *devlink_port, void *priv, char *parent_name)
> {
> struct devlink *devlink = devlink_port->devlink;
> struct devlink_rate *devlink_rate;
> + struct devlink_rate *parent;
>
net/core/devlink.c:10332: warning: Function parameter or member 'parent_name' not described in 'devl_rate_leaf_create'
next prev parent reply other threads:[~2022-10-28 3:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 13:00 [PATCH net-next v7 0/9] Implement devlink-rate API and extend it Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 1/9] devlink: Introduce new parameter 'tx_priority' to devlink-rate Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 2/9] devlink: Introduce new parameter 'tx_weight' " Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 3/9] devlink: Enable creation of the devlink-rate nodes from the driver Michal Wilczynski
2022-10-27 21:27 ` Przemek Kitszel
2022-10-28 8:51 ` Wilczynski, Michal
2022-10-27 13:00 ` [PATCH net-next v7 4/9] devlink: Allow for devlink-rate nodes parent reassignment Michal Wilczynski
2022-10-27 22:34 ` Przemek Kitszel
2022-10-28 9:35 ` Wilczynski, Michal
2022-10-27 13:00 ` [PATCH net-next v7 5/9] devlink: Allow to set up parent in devl_rate_leaf_create() Michal Wilczynski
2022-10-28 3:28 ` Jakub Kicinski [this message]
2022-10-27 13:00 ` [PATCH net-next v7 6/9] devlink: Allow to change priv in devlink-rate from parent_set callbacks Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 7/9] ice: Introduce new parameters in ice_sched_node Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 8/9] ice: Implement devlink-rate API Michal Wilczynski
2022-10-27 13:00 ` [PATCH net-next v7 9/9] ice: Prevent ADQ, DCB, RDMA coexistence with Custom Tx scheduler Michal Wilczynski
2022-10-28 3:28 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221027202827.701a9a68@kernel.org \
--to=kuba@kernel.org \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jiri@resnulli.us \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.