From: Kanchan Joshi <joshi.k@samsung.com>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
chaitanyak@nvidia.com, axboe@kernel.dk,
Keith Busch <kbusch@kernel.org>, Daniel Wagner <dwagner@suse.de>,
Alan Adamson <alan.adamson@oracle.com>
Subject: Re: [PATCHv2] nvme: quiet user passthrough command errors
Date: Fri, 28 Oct 2022 10:53:18 +0530 [thread overview]
Message-ID: <20221028052318.GA4034@test-zns> (raw)
In-Reply-To: <20221027150417.1954662-1-kbusch@meta.com>
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Thu, Oct 27, 2022 at 08:04:17AM -0700, Keith Busch wrote:
>From: Keith Busch <kbusch@kernel.org>
>
>The driver is spamming the kernel logs for entirely harmless errors from
>user space submitting unsupported commands. Just silence the errors.
>The application has direct access to command status, so there's no need
>to log these.
>
>And since every passthrough command wants the quiet flag, move the
>setting to every user's common initializer.
>
>Cc: Daniel Wagner <dwagner@suse.de>
>Cc: Alan Adamson <alan.adamson@oracle.com>
>Signed-off-by: Keith Busch <kbusch@kernel.org>
>---
>v1->v2:
>
> Set the quiet flag in the common initializer instead of open coding
> the flag for each path.
now open coding can be removed in pci.c too. That is still being done at
two places.
With those changes in -
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2022-10-28 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221027151545epcas5p4b0d216b828a5c33ec15ff84e7f847e52@epcas5p4.samsung.com>
2022-10-27 15:04 ` [PATCHv2] nvme: quiet user passthrough command errors Keith Busch
2022-10-27 15:31 ` Daniel Wagner
2022-10-28 5:23 ` Kanchan Joshi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028052318.GA4034@test-zns \
--to=joshi.k@samsung.com \
--cc=alan.adamson@oracle.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=dwagner@suse.de \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.