From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
hch@lst.de, djwong@kernel.org, bvanassche@acm.org,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] iomap: directly use logical block size
Date: Sun, 30 Oct 2022 09:27:49 +0100 [thread overview]
Message-ID: <20221030082749.GA4949@lst.de> (raw)
In-Reply-To: <20221026165133.2563946-1-kbusch@meta.com>
On Wed, Oct 26, 2022 at 09:51:33AM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Don't transform the logical block size to a bit shift only to shift it
> back to the original block size. Just use the size.
This looks reasonable. But given that the blksz variable is only used
once, why not open code the bdev_logical_block_size in the conditional?
prev parent reply other threads:[~2022-10-30 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 16:51 [PATCH] iomap: directly use logical block size Keith Busch
2022-10-26 18:06 ` Chaitanya Kulkarni
2022-10-26 18:33 ` Darrick J. Wong
2022-10-28 21:41 ` Bart Van Assche
2022-10-30 8:27 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030082749.GA4949@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=djwong@kernel.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.