From: Christoph Hellwig <hch@lst.de>
To: Konstantin Shelekhin <k.shelekhin@yadro.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Aleksandr Miloserdov <a.miloserdov@yadro.com>,
Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <kch@nvidia.com>,
linux-nvme@lists.infradead.org, linux@yadro.com,
Dmitriy Bogdanov <d.bogdanov@yadro.com>
Subject: Re: [PATCH 2/3] nvmet: expose IEEE OUI to configfs
Date: Sun, 30 Oct 2022 09:29:05 +0100 [thread overview]
Message-ID: <20221030082905.GC4949@lst.de> (raw)
In-Reply-To: <Y1u+D80ohMF8bbPJ@yadro.com>
On Fri, Oct 28, 2022 at 02:33:35PM +0300, Konstantin Shelekhin wrote:
> While there: we have a little internal bikeshedding on how to actually
> name the ConfigFS parameter :D
>
> Weirdly in this part of the spec it's called IEEE instead of OUI,
> however in other parts (like EUI64 generation) it's referenced as OUI.
> To the end user it makes more sense to call it simply OUI. So basically
> we have:
>
> attr_ieee
> attr_oui
> attr_ieee_oui
>
> Purely a style nitpicking, but what's your stance?
The NVMe naming is indeed rather odd. I'd be tempted to just follow
it anyway.
next prev parent reply other threads:[~2022-10-30 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 8:31 [PATCH 0/3] Allow user to set nvmet firmware revision and IEEE OUI Aleksandr Miloserdov
2022-10-26 8:31 ` [PATCH 1/3] nvmet: fix memory leak in configfs Aleksandr Miloserdov
2022-10-26 10:49 ` Sagi Grimberg
2022-11-01 7:52 ` Christoph Hellwig
2022-10-26 8:31 ` [PATCH 2/3] nvmet: expose IEEE OUI to configfs Aleksandr Miloserdov
2022-10-26 10:49 ` Sagi Grimberg
2022-10-27 12:48 ` Aleksandr Miloserdov
2022-10-28 11:33 ` Konstantin Shelekhin
2022-10-30 8:29 ` Christoph Hellwig [this message]
2022-10-26 8:31 ` [PATCH 3/3] nvmet: expose firmware revision " Aleksandr Miloserdov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221030082905.GC4949@lst.de \
--to=hch@lst.de \
--cc=a.miloserdov@yadro.com \
--cc=d.bogdanov@yadro.com \
--cc=k.shelekhin@yadro.com \
--cc=kch@nvidia.com \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@yadro.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.