Re: [Buildroot] [PATCH 1/4] package/alsa-lib: disable topology modules for static builds

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Fri, 28 Oct 2022 21:15:23 +0200
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> With this fix to alsa-lib we can remove a patch from alsa-utils which
> fixed its static build. A static build of topology modules is not
> supported by upstream however:
> 
> "Note that it does not make sense to build static topology modules.
>  They are not usable."
> https://github.com/alsa-project/alsa-utils/issues/152#issuecomment-1144485929
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/alsa-lib/alsa-lib.mk                  |  1 +
>  ...nfigure.ac-fix-build-without-dlfcn.h.patch | 48 -------------------
>  package/alsa-utils/alsa-utils.mk              |  3 --
>  3 files changed, 1 insertion(+), 51 deletions(-)
>  delete mode 100644 package/alsa-utils/0003-configure.ac-fix-build-without-dlfcn.h.patch
> 
> diff --git a/package/alsa-lib/alsa-lib.mk b/package/alsa-lib/alsa-lib.mk
> index f3ed195a5c..6e474aa5e2 100644
> --- a/package/alsa-lib/alsa-lib.mk
> +++ b/package/alsa-lib/alsa-lib.mk
> @@ -25,6 +25,7 @@ endif
>  # Can't build with static & shared at the same time (1.0.25+)
>  ifeq ($(BR2_STATIC_LIBS),y)
>  ALSA_LIB_CONF_OPTS += \
> +	--disable-topology \

I think we should make this an explicit Config.in option of the
alsa-lib package, which depends on !BR2_STATIC_LIBS, so that the
packages that need that library can then select this option, and
properly propagate the !BR2_STATIC_LIBS dependency.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot