All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/binutils: prevent selecting 2.37 for AVX512 systems
Date: Sun, 30 Oct 2022 20:33:06 +0100	[thread overview]
Message-ID: <20221030193306.GD1058960@scaer> (raw)
In-Reply-To: <20221026175430.3927965-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-10-26 19:54 +0200, Thomas Petazzoni via buildroot spake thusly:
> Support for the AVX512FP16 instructions was added in binutils
> 2.38. See the binutils 2.38 releases notes [0] that state:
>     X86:
>     [...]
>       * Add support for Intel AVX512_FP16 instructions.
[--SNIP--]
> Also, in Buildroot, we do not distinguish AVX512 in general from
> AVX512FP16 specifically, so our only option is to make binutils 2.37
> unavailable for AVX512 systems even if some of them perhaps don't
> support AVX512FP16 anyway. This seems like a reasonable trade-off, as
> binutils 2.38 is anyway already the default in Buildroot, and
> AVX512-capable systems are fairly recent, and therefore using a recent
> binutils version should not be a problem on these platforms.

ACK

> Fixes:
> 
>   http://autobuild.buildroot.net/results/eb6e28c934654e6d714973415a2fb452f9580279/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/binutils/Config.in.host | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index 51802db043..5dd2af2f9c 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -14,6 +14,9 @@ choice
>  
>  config BR2_BINUTILS_VERSION_2_37_X
>  	bool "binutils 2.37"
> +	# AVX512FP16 instructions were not supported before binutils
> +	# 2.38
> +	depends on !BR2_X86_CPU_HAS_AVX512
>  
>  config BR2_BINUTILS_VERSION_2_38_X
>  	bool "binutils 2.38"
> -- 
> 2.37.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-10-30 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 17:54 [Buildroot] [PATCH] package/binutils: prevent selecting 2.37 for AVX512 systems Thomas Petazzoni via buildroot
2022-10-30 19:33 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221030193306.GD1058960@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.