Re: [Buildroot] [PATCH v2] package/rtl8188eu: remove wrong description in Config.in

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, 19 Oct 2022 15:48:23 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> This rtl8188eu driver is not the same as the one in mainline Linux that
> still has pending work to be done that in this driver is done, check:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO
> specifically:
> * Switch to use LIB80211.
> * Switch to use MAC80211.
> * Switch to use CFG80211.
> So let's remove the description that is not valid anymore.
> 
> Suggested-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * improve Config.in description as pointed by Luca Ceresoli
> ---
>  package/rtl8188eu/Config.in | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/rtl8188eu/Config.in b/package/rtl8188eu/Config.in
> index 76d9085297..2fab1fd5c0 100644
> --- a/package/rtl8188eu/Config.in
> +++ b/package/rtl8188eu/Config.in
> @@ -4,9 +4,10 @@ config BR2_PACKAGE_RTL8188EU
>  	depends on BR2_LINUX_KERNEL
>  	help
>  	  A standalone driver for the RTL8188EU USB Wi-Fi adapter.
> -	  This is needed only for Linux kernels before 3.12.
> -	  Since 3.12, there is a (staging) driver in mainline, with a
> -	  similar codebase.
> +	  This rtl8188eu driver is not the same as the one in mainline
> +	  Linux that still has pending work to be done that in this
> +	  driver is done, check:
> +	  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/r8188eu/TODO

I don't see any thing in this TODO that explains why the out-of-tree
driver is better than the mainline driver.

The out-of-tree driver has been integrated into drivers/staging/, and
this TODO file lists what should be improved in the driver so that it
can be graduated to move outside of drivers/staging/ into the proper
drivers/net/wireless/ location.

I don't see anything in this TODO that indicates that the out-of-tree
driver has "more features" than the mainline driver, so to me the
Config.in help text still makes sense.

Could you give some more details?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot