Re: [PATCH v3 0/8] AArch64/HMAT support and tests

[Jonathan Cameron via <qemu-devel@nongnu.org>]

On Mon, 31 Oct 2022 13:17:17 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Fri, 28 Oct 2022 17:53:40 +0800
> Yicong Yang <yangyicong@huawei.com> wrote:
> 
> > Hi Hesham,
> > 
> > On 2022/10/27 18:00, Hesham Almatary wrote:
> > > This patchset adds support for AArch64/HMAT including a test.
> > > It relies on other two patch sets from:
> > > 
> > > Brice Goglin: to support -numa without initiators on q35/x86.
> > >   https://lore.kernel.org/all/ed23accb-2c8b-90f4-a7a3-f81cc57bf678@inria.fr/
> > > Xiang Chen: to enable/support HMAT on AArch64.
> > >   https://lore.kernel.org/all/1643102134-15506-1-git-send-email-chenxiang66@hisilicon.com/
> > > 
> > > I further add a test with ACPI/HMAT tables that uses the two
> > > patch sets.
> > >   
> > 
> > You seems to forget my tag :)
> > 
> > Anyway tested again for this series on master of commit
> > 052924548886, still works well and all tests passed for
> > qemu-system-aarch64.
> > 
> > Tested-by: Yicong Yang <yangyicong@hisilicon.com>
> 
> Hi,
> 
> Michael, I think you said you'd pick this one up? (it hit during last
> freeze) Just want to confirm in case everyone was assuming this was
> someone else's problem ;) I want to add a bunch of stuff on top of
> this next cycle (Generic Ports in particular) so good to get this in
> place if we can.

Doh.  Failed to spot your pull request due to my local email filtering house of cards.
 Ignore me ;)

Jonathan


> 
> Jonathan
> 
> > 
> > > Changes from v2:
> > > - Rebased and fixed a merge conflict
> > > 
> > > Changes from v1:
> > > - Generate APIC and PPTT ACPI tables for AArch64/virt
> > > - Avoid using legacy syntax in numa/bios tests
> > > - Delete unchanged FACP tables
> > > 
> > > Brice Goglin (4):
> > >   hmat acpi: Don't require initiator value in -numa
> > >   tests: acpi: add and whitelist *.hmat-noinitiator expected blobs
> > >   tests: acpi: q35: add test for hmat nodes without initiators
> > >   tests: acpi: q35: update expected blobs *.hmat-noinitiators
> > > expected HMAT:
> > > 
> > > Hesham Almatary (3):
> > >   tests: Add HMAT AArch64/virt empty table files
> > >   tests: acpi: aarch64/virt: add a test for hmat nodes with no
> > >     initiators
> > >   tests: virt: Update expected *.acpihmatvirt tables
> > > 
> > > Xiang Chen (1):
> > >   hw/arm/virt: Enable HMAT on arm virt machine
> > > 
> > >  hw/arm/Kconfig                                |   1 +
> > >  hw/arm/virt-acpi-build.c                      |   7 ++
> > >  hw/core/machine.c                             |   4 +-
> > >  tests/data/acpi/q35/APIC.acpihmat-noinitiator | Bin 0 -> 144
> > > bytes tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 0 ->
> > > 8553 bytes tests/data/acpi/q35/HMAT.acpihmat-noinitiator | Bin 0
> > > -> 288 bytes tests/data/acpi/q35/SRAT.acpihmat-noinitiator | Bin
> > > 0 -> 312 bytes tests/data/acpi/virt/APIC.acpihmatvirt        |
> > > Bin 0 -> 396 bytes tests/data/acpi/virt/DSDT.acpihmatvirt
> > > | Bin 0 -> 5282 bytes tests/data/acpi/virt/HMAT.acpihmatvirt
> > >   | Bin 0 -> 288 bytes tests/data/acpi/virt/PPTT.acpihmatvirt
> > >    | Bin 0 -> 196 bytes tests/data/acpi/virt/SRAT.acpihmatvirt
> > >     | Bin 0 -> 240 bytes tests/qtest/bios-tables-test.c
> > >      | 109 ++++++++++++++++++ 13 files changed, 118
> > > insertions(+), 3 deletions(-) create mode 100644
> > > tests/data/acpi/q35/APIC.acpihmat-noinitiator create mode 100644
> > > tests/data/acpi/q35/DSDT.acpihmat-noinitiator create mode 100644
> > > tests/data/acpi/q35/HMAT.acpihmat-noinitiator create mode 100644
> > > tests/data/acpi/q35/SRAT.acpihmat-noinitiator create mode 100644
> > > tests/data/acpi/virt/APIC.acpihmatvirt create mode 100644
> > > tests/data/acpi/virt/DSDT.acpihmatvirt create mode 100644
> > > tests/data/acpi/virt/HMAT.acpihmatvirt create mode 100644
> > > tests/data/acpi/virt/PPTT.acpihmatvirt create mode 100644
> > > tests/data/acpi/virt/SRAT.acpihmatvirt 
>