From: Jiri Benc <jbenc@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org,
Shmulik Ladkani <shmulik@metanetworks.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Tomas Hruby <tomas@tigera.io>,
Jeremi Piotrowski <jpiotrowski@linux.microsoft.com>,
alexanderduyck@meta.com, willemb@google.com,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net] net: gso: fix panic on frag_list with mixed head alloc types
Date: Mon, 31 Oct 2022 16:54:48 +0100 [thread overview]
Message-ID: <20221031165448.48533b8e@griffin> (raw)
In-Reply-To: <20221028214123.1ac0fc87@kernel.org>
On Fri, 28 Oct 2022 21:41:23 -0700, Jakub Kicinski wrote:
> On Thu, 27 Oct 2022 10:20:56 +0200 Jiri Benc wrote:
> > It turns out this assumption does not hold. We've seen BUG_ON being hit
> > in skb_segment when skbs on the frag_list had differing head_frag. That
> > particular case was with vmxnet3; looking at the driver, it indeed uses
> > different skb allocation strategies based on the packet size.
>
> Where are you looking? I'm not seeing it TBH.
Looking at the code again, I think I misread it.
> I don't think the driver is that important, tho, __napi_alloc_skb()
> will select page backing or kmalloc, all by itself.
In this case, it was __netdev_alloc_skb. I'll fix the description.
Thanks!
Jiri
next prev parent reply other threads:[~2022-10-31 15:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 8:20 [PATCH net] net: gso: fix panic on frag_list with mixed head alloc types Jiri Benc
2022-10-29 4:41 ` Jakub Kicinski
2022-10-31 15:54 ` Jiri Benc [this message]
2022-10-29 7:41 ` Shmulik Ladkani
2022-10-29 14:10 ` Willem de Bruijn
2022-10-31 16:52 ` Jiri Benc
2022-10-31 21:16 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031165448.48533b8e@griffin \
--to=jbenc@redhat.com \
--cc=alexanderduyck@meta.com \
--cc=eric.dumazet@gmail.com \
--cc=jpiotrowski@linux.microsoft.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shmulik@metanetworks.com \
--cc=tomas@tigera.io \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.