From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Christian Stewart <christian@paral.in>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/docker-compose: bump to version 2.10.0
Date: Mon, 31 Oct 2022 23:02:27 +0100 [thread overview]
Message-ID: <20221031230227.222d7ad1@windsurf> (raw)
In-Reply-To: <20220904191010.200822-1-christian@paral.in>
Hello Christian,
On Sun, 4 Sep 2022 12:10:10 -0700
Christian Stewart via buildroot <buildroot@buildroot.org> wrote:
> -$(eval $(python-package))
> +DOCKER_COMPOSE_BUILD_TARGETS = cmd
> +DOCKER_COMPOSE_GOMOD = github.com/docker/compose/v2
> +DOCKER_COMPOSE_LDFLAGS = \
> + -X github.com/docker/compose/v2/internal.Version=$(DOCKER_COMPOSE_VERSION)
> +
> +define DOCKER_COMPOSE_INSTALL_TARGET_CMDS
> + $(INSTALL) -D -m 755 $(@D)/bin/cmd \
> + $(TARGET_DIR)/usr/lib/docker/cli-plugins/docker-compose
> +endef
> +
> +$(eval $(golang-package))
It looks like this commit has broken our docker compose test case
(support/testing/tests/package/test_docker_compose.py). Indeed, this
test expects to be able to run a command called "docker-compose", which
no longer exists, so the test fails with:
# docker-compose up -d
-sh: docker-compose: not found
# echo $?
127
See:
https://gitlab.com/buildroot.org/buildroot/-/jobs/3249828442
https://buildroot.org.gitlab.io/-/buildroot/-/jobs/3249828442/artifacts/test-output/TestDockerCompose-build.log
https://buildroot.org.gitlab.io/-/buildroot/-/jobs/3249828442/artifacts/test-output/TestDockerCompose-run.log
Could have a look and provide a patch to fix this test case?
Also, could you send a patch adding yourself in the DEVELOPERS file for
this test case, since you're often looking after Docker related topics
in Buildroot?
Thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-10-31 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 19:10 [Buildroot] [PATCH v1 1/1] package/docker-compose: bump to version 2.10.0 Christian Stewart via buildroot
2022-09-04 19:41 ` Yann E. MORIN
2022-09-04 20:02 ` Christian Stewart via buildroot
2022-09-05 14:08 ` Yann E. MORIN
2022-09-06 8:22 ` Yann E. MORIN
2022-10-31 22:02 ` Thomas Petazzoni via buildroot [this message]
2022-10-31 22:08 ` Christian Stewart via buildroot
2022-10-31 22:31 ` Thomas Petazzoni via buildroot
2022-11-01 0:32 ` Christian Stewart via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031230227.222d7ad1@windsurf \
--to=buildroot@buildroot.org \
--cc=christian@paral.in \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.