From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: edward.cree@amd.com, netdev@vger.kernel.org,
linux-net-drivers@amd.com, davem@davemloft.net,
pabeni@redhat.com, edumazet@google.com, habetsm.xilinx@gmail.com
Subject: Re: [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload
Date: Tue, 1 Nov 2022 08:50:34 -0700 [thread overview]
Message-ID: <20221101085034.44b94d10@kernel.org> (raw)
In-Reply-To: <279a6644-4f3e-2ef3-2aa4-4463fbb9b8fc@gmail.com>
On Tue, 1 Nov 2022 15:41:13 +0000 Edward Cree wrote:
> > Can you describe the current behavior is? Isn't the driver accepting
> > rules it can't correctly offload?
>
> The rule will pass the checks here, but then when we make the MCDI call
> to install it in hardware, MC_CMD_MAE_ACTION_RULE_INSERT will evoke an
> error response from the firmware, so the TC_SETUP_CLSFLOWER callback
> will ultimately return an error to the kernel as it should.
> The advantage of having these checks in the driver is that we get a
> useful error message rather than just "Failed to insert rule in hw",
> and also save the round trip across the PCIe bus to firmware.
I see, net-next sounds good then. Do put this info into the commit
message, please.
next prev parent reply other threads:[~2022-11-01 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 9:29 [PATCH net-next 0/5] sfc: add basic flower matches to offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 1/5] sfc: check recirc_id match caps before MAE offload edward.cree
2022-10-26 2:40 ` Jakub Kicinski
2022-11-01 13:30 ` Edward Cree
2022-11-01 15:21 ` Jakub Kicinski
2022-11-01 15:41 ` Edward Cree
2022-11-01 15:50 ` Jakub Kicinski [this message]
2022-10-24 9:29 ` [PATCH net-next 2/5] sfc: add Layer 2 matches to ef100 TC offload edward.cree
2022-10-24 9:29 ` [PATCH net-next 3/5] sfc: add Layer 3 " edward.cree
2022-10-24 9:29 ` [PATCH net-next 4/5] sfc: add Layer 3 flag " edward.cree
2022-10-24 9:29 ` [PATCH net-next 5/5] sfc: add Layer 4 " edward.cree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101085034.44b94d10@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=edward.cree@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=linux-net-drivers@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.