From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 921EBFA3743 for ; Tue, 1 Nov 2022 10:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667297728; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=p+RlVzvLTHnVHaIYFBUw1H32N90Sd9UJ3Y80Yir/Qss=; b=AOMkYoAaZf6Tdlhl45G57jbDdlYXRQsebZ0TVHk/2KSFaU/M+kjZYbvho3eZbKetrifX6N nMUqaaHV38NPVTCq/bG4bRlzuBJef83977wxrrEhwM15oBcqZpcmPrXW/cAaMfnouJJJJe ay8WYThFv6iQEPXSu1TUdoo5gzPrwAU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-627-YLTdjqcOOXiSEpsOk6ownQ-1; Tue, 01 Nov 2022 06:15:25 -0400 X-MC-Unique: YLTdjqcOOXiSEpsOk6ownQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B4EED101A54E; Tue, 1 Nov 2022 10:15:22 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35865140EBF3; Tue, 1 Nov 2022 10:15:21 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F153519465B3; Tue, 1 Nov 2022 10:15:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 63DB31946594 for ; Tue, 1 Nov 2022 10:15:19 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 517C7C1912A; Tue, 1 Nov 2022 10:15:19 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A5E4C15BA5 for ; Tue, 1 Nov 2022 10:15:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30A1729ABA13 for ; Tue, 1 Nov 2022 10:15:19 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-284-4vUQ8z25NXixPhqPIbFAXQ-1; Tue, 01 Nov 2022 06:15:16 -0400 X-MC-Unique: 4vUQ8z25NXixPhqPIbFAXQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id B77FD68AA6; Tue, 1 Nov 2022 11:15:11 +0100 (CET) Date: Tue, 1 Nov 2022 11:15:11 +0100 From: Christoph Hellwig To: Mike Christie Message-ID: <20221101101511.GA13304@lst.de> References: <20221026231945.6609-1-michael.christie@oracle.com> <20221026231945.6609-13-michael.christie@oracle.com> <20221030082020.GC4774@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Subject: Re: [dm-devel] [PATCH v3 12/19] block, nvme, scsi, dm: Add blk_status to pr_ops callouts X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: axboe@kernel.dk, linux-block@vger.kernel.org, chaitanyak@nvidia.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, snitzer@kernel.org, linux-nvme@lists.infradead.org, james.bottomley@hansenpartnership.com, dm-devel@redhat.com, target-devel@vger.kernel.org, kbusch@kernel.org, Christoph Hellwig , bvanassche@acm.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gU3VuLCBPY3QgMzAsIDIwMjIgYXQgMDY6MDU6MzVQTSAtMDUwMCwgTWlrZSBDaHJpc3RpZSB3 cm90ZToKPiBUaGUgcHJvYmxlbSBJIGhpdCBpcyB0aGF0IGluIHRoZSBpb2N0bCBjb2RlIEkgdGhl biBoYXZlIHRvIGRvOgo+IAo+IEBAIC0yNjksNyArMjcwLDE0IEBAIHN0YXRpYyBpbnQgYmxrZGV2 X3ByX3JlZ2lzdGVyKHN0cnVjdCBibG9ja19kZXZpY2UgKmJkZXYsCj4gIAo+ICAJaWYgKHJlZy5m bGFncyAmIH5QUl9GTF9JR05PUkVfS0VZKQo+ICAJCXJldHVybiAtRU9QTk9UU1VQUDsKPiAtCXJl dHVybiBvcHMtPnByX3JlZ2lzdGVyKGJkZXYsIHJlZy5vbGRfa2V5LCByZWcubmV3X2tleSwgcmVn LmZsYWdzKTsKPiArCXJldCA9IG9wcy0+cHJfcmVnaXN0ZXIoYmRldiwgcmVnLm9sZF9rZXksIHJl Zy5uZXdfa2V5LCByZWcuZmxhZ3MpOwo+ICsJaWYgKHJldCA9PSAtRUJBREUpIHsKPiArCQlpZiAo YmRldl9pc19udm1lKGJkZXYpKQo+ICsJCQlyZXQgPSBOVk1FX1NDX1JFU0VSVkFUSU9OX0NPTkZM SUNUOwo+ICsJCWVsc2UgaWYgKGJkZXZfaXNfc2NzaShiZGV2KQo+ICsJCQlyZXQgPSBTQU1fU1RB VF9SRVNFUlZBVElPTl9DT05GTElDVDsKPiArCX0KPiArCXJldHVybiByZXQ7CgpFd3cuICBXZSBz aG91bGQgaGF2ZSBuZXZlciBsZWFrZWQgcHJvdG9jb2wgc3BlY2lmaWMgdmFsdWVzIG91dCB0bwp1 c2Vyc3BhY2UuICBUaGlzIGlzIGFuIG9yaWdpbmFsIGJ1ZyBJIGludHJvZHVjZdGVLCBzbyBhbGwg YmxhbWUgaXMgb24gbWUuCgpJIHN1c3BlY3QgdGhlIHJpZ2h0IHdheSB0byBmaXggaXMgaXMgdG8g a2VlcCB0aGUgbnVtZXJpYyB2YWx1ZSBvZgpTQU1fU1RBVF9SRVNFUlZBVElPTl9DT05GTElDVCBh bmQgZ2l2ZSBpdCBhIG5ldyBjb25zdGFudCBleHBvc2VkIGluCnRoZSB1YXBpIGhlYWRlciwgYXNz dW1pbmcgdGhhdCBTQ1NJIGlzIHRoZSB0aGluZyBwZW9wbGUgYWN0dWFsbHkKdXNlZCB0aGUgUFIg QVBJIGZvciwgYW5kIG52bWUgd2FzIGp1c3QgYW4gbmljZSBsaXR0bGUgYWRkLW9uLgoKTm93IGlm IGFuIGVycm5vIHZhbHVlIG9yIGJsa19zdGF0dXNfdCBpcyByZXR1cm5lZCBmcm9tIHRoZSBtZXRo b2QKc2hvdWxkIG5vdCBtYXR0ZXIgZm9yIHRoaXMgZml4LCBidXQgaW4gdGhlIGxvbmcgcnVuIEkg dGhpbmsgdGhlCmJsa19zdGF0dXNfdCB3b3VsZCBiZSBjbGVhbmVyIHRoYW4gdGhlIGludCB1c2Vk IGZvciBlcnJubywgYW5kCnRoYXQgd2lsbCBhbHNvIHByZXZlbnQgdXMgZnJvbSByZXR1cm5pbmcg YWNjaWRlbnRhbCBub24taW50ZW5kZWQKdmFsdWVzLgoKQnR3LCBJIGFsc28gdGhpbmcgd2Ugc2hv dWxkIHJlbmFtZSBCTEtfU1RTX05FWFVTIHRvCkJMS19TVFNfUkVTRVJWQVRJT05fQ09ORkxJQ1Qg KGFzc3VtaW5nIHMzOTAgaXMgb2sgd2l0aCB0aGF0KSwgYXMgdGhhdApoYXMgbXVjaCBiZXR0ZXIg ZG9jdW1lbnRhcnkgdmFsdWUuCgo+ICsJY2FzZSBCTEtfU1RTX1RSQU5TUE9SVDoKPiArCQlpZiAo YmRldl9pc19udm1lKGJkZXYpKQo+ICsJCQlyZXQgPSBOVk1FX1NDX0hPU1RfUEFUSF9FUlJPUjsK PiArCQllbHNlIGlmIChiZGV2X2lzX3Njc2koYmRldikKPiArCQkJcmV0ID0gRElEX1RSQU5TUE9S VF9GQUlMRkFTVCBvciBESURfVFJBTlNQT1JUX01BUkdJTkFMOwo+ICsJCWJyZWFrOwoKQW5kIHdl J2xsIG5lZWQgYW4gdWFwaSB2YWx1ZSBmb3IgdGhpcyBhcyB3ZWxsLgoKPiArCWNhc2UgQkxLX1NU U19OT1RTVVBQOgoKYW5kIG1heWJlIHRoaXMgdW5sZXNzIHdlIGNhbiBqdXN0IGdldCBhd2F5IHdp dGggdGhlIG5lZ2F0aXZlIGVycm5vCnZhbHVlLgoKLS0KZG0tZGV2ZWwgbWFpbGluZyBsaXN0CmRt LWRldmVsQHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0bWFuLnJlZGhhdC5jb20vbWFpbG1hbi9saXN0 aW5mby9kbS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C85FA3745 for ; Tue, 1 Nov 2022 10:15:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229930AbiKAKPS (ORCPT ); Tue, 1 Nov 2022 06:15:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbiKAKPR (ORCPT ); Tue, 1 Nov 2022 06:15:17 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B1263A2; Tue, 1 Nov 2022 03:15:17 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id B77FD68AA6; Tue, 1 Nov 2022 11:15:11 +0100 (CET) Date: Tue, 1 Nov 2022 11:15:11 +0100 From: Christoph Hellwig To: Mike Christie Cc: Christoph Hellwig , bvanassche@acm.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, james.bottomley@hansenpartnership.com, linux-block@vger.kernel.org, dm-devel@redhat.com, snitzer@kernel.org, axboe@kernel.dk, linux-nvme@lists.infradead.org, chaitanyak@nvidia.com, kbusch@kernel.org, target-devel@vger.kernel.org Subject: Re: [PATCH v3 12/19] block,nvme,scsi,dm: Add blk_status to pr_ops callouts Message-ID: <20221101101511.GA13304@lst.de> References: <20221026231945.6609-1-michael.christie@oracle.com> <20221026231945.6609-13-michael.christie@oracle.com> <20221030082020.GC4774@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Oct 30, 2022 at 06:05:35PM -0500, Mike Christie wrote: > The problem I hit is that in the ioctl code I then have to do: > > @@ -269,7 +270,14 @@ static int blkdev_pr_register(struct block_device *bdev, > > if (reg.flags & ~PR_FL_IGNORE_KEY) > return -EOPNOTSUPP; > - return ops->pr_register(bdev, reg.old_key, reg.new_key, reg.flags); > + ret = ops->pr_register(bdev, reg.old_key, reg.new_key, reg.flags); > + if (ret == -EBADE) { > + if (bdev_is_nvme(bdev)) > + ret = NVME_SC_RESERVATION_CONFLICT; > + else if (bdev_is_scsi(bdev) > + ret = SAM_STAT_RESERVATION_CONFLICT; > + } > + return ret; Eww. We should have never leaked protocol specific values out to userspace. This is an original bug I introduceѕ, so all blame is on me. I suspect the right way to fix is is to keep the numeric value of SAM_STAT_RESERVATION_CONFLICT and give it a new constant exposed in the uapi header, assuming that SCSI is the thing people actually used the PR API for, and nvme was just an nice little add-on. Now if an errno value or blk_status_t is returned from the method should not matter for this fix, but in the long run I think the blk_status_t would be cleaner than the int used for errno, and that will also prevent us from returning accidental non-intended values. Btw, I also thing we should rename BLK_STS_NEXUS to BLK_STS_RESERVATION_CONFLICT (assuming s390 is ok with that), as that has much better documentary value. > + case BLK_STS_TRANSPORT: > + if (bdev_is_nvme(bdev)) > + ret = NVME_SC_HOST_PATH_ERROR; > + else if (bdev_is_scsi(bdev) > + ret = DID_TRANSPORT_FAILFAST or DID_TRANSPORT_MARGINAL; > + break; And we'll need an uapi value for this as well. > + case BLK_STS_NOTSUPP: and maybe this unless we can just get away with the negative errno value.