From: Bjorn Helgaas <helgaas@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: mani@kernel.org, allenbh@gmail.com, bhelgaas@google.com,
dave.jiang@intel.com, imx@lists.linux.dev, jdmason@kudzu.us,
kw@linux.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
ntb@lists.linux.dev
Subject: Re: [PATCH v15 0/7] pci-epf-vntb clean up
Date: Tue, 1 Nov 2022 12:20:06 -0500 [thread overview]
Message-ID: <20221101172006.GA1264778@bhelgaas> (raw)
In-Reply-To: <20221101165709.983416-1-Frank.Li@nxp.com>
On Tue, Nov 01, 2022 at 12:57:02PM -0400, Frank Li wrote:
> continue patch series https://www.spinics.net/lists/linux-pci/msg130372.html
> https://www.spinics.net/lists/linux-pci/msg130924.html
>
> Lorenzo suggest create new series. Version number continue from old one
>
> Change from v14-v15
> Fixed according to Manivannan Sadhasivam's comments, except endian
> problem. Endian problem is out of this patch series scope.
> kernel test robot report sparse build warning problem already fixed
> at patch 6 and 7.
>
> Change from v13-v14
> split spare warning fix to two patch
> remove local variable reorder
>
> Frank Li (7):
> PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning
> PCI: endpoint: pci-epf-vntb: Fix indentation of the struct
> epf_ntb_ctrl
> PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err
> path
> PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy
> PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32)
> PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db
> PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg
Please capitalize your subject lines consistently. You have two
capitalized:
> PCI: endpoint: pci-epf-vntb: Clean up ...
> PCI: endpoint: pci-epf-vntb: Fix indentation ...
and a bunch that aren't:
> PCI: endpoint: pci-epf-vntb: fix call ...
> PCI: endpoint: pci-epf-vntb: remove unused ...
> ...
Also add "()" after function names:
PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr() ...
prev parent reply other threads:[~2022-11-01 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 16:57 [PATCH v15 0/7] pci-epf-vntb clean up Frank Li
2022-11-01 16:57 ` [PATCH v15 1/7] PCI: endpoint: pci-epf-vntb: Clean up kernel_doc warning Frank Li
2022-11-01 16:57 ` [PATCH v15 2/7] PCI: endpoint: pci-epf-vntb: Fix indentation of the struct epf_ntb_ctrl Frank Li
2022-11-01 16:57 ` [PATCH v15 3/7] PCI: endpoint: pci-epf-vntb: fix call pci_epc_mem_free_addr at err path Frank Li
2022-11-01 16:57 ` [PATCH v15 4/7] PCI: endpoint: pci-epf-vntb: remove unused field epf_db_phy Frank Li
2022-11-01 16:57 ` [PATCH v15 5/7] PCI: endpoint: pci-epf-vntb: replace hardcode 4 with sizeof(u32) Frank Li
2022-11-01 16:57 ` [PATCH v15 6/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at epf_db Frank Li
2022-11-01 16:57 ` [PATCH v15 7/7] PCI: endpoint: pci-epf-vntb: fix sparse build warning at ntb->reg Frank Li
2022-11-01 17:20 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101172006.GA1264778@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=ntb@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.