From: Asutosh Das <quic_asutoshd@quicinc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
<linux-scsi@vger.kernel.org>, <quic_nguyenb@quicinc.com>,
<quic_xiaosenh@quicinc.com>, <stanley.chu@mediatek.com>,
<eddie.huang@mediatek.com>, <daejun7.park@samsung.com>,
<avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
<quic_richardp@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue capability
Date: Tue, 1 Nov 2022 11:47:19 -0700 [thread overview]
Message-ID: <20221101184718.GG9077@asutoshd-linux1.qualcomm.com> (raw)
In-Reply-To: <c03ac1f5-e4a4-c26a-c1f5-b4e78cae3472@acm.org>
On Fri, Oct 28 2022 at 15:08 -0700, Bart Van Assche wrote:
>On 10/20/22 11:03, Asutosh Das wrote:
>>diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>>index 36c40210..b740299 100644
>>--- a/drivers/ufs/host/ufs-qcom.c
>>+++ b/drivers/ufs/host/ufs-qcom.c
>>@@ -853,6 +853,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba)
>> hba->caps |= UFSHCD_CAP_CRYPTO;
>> hba->caps |= UFSHCD_CAP_AGGR_POWER_COLLAPSE;
>> hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
>>+ hba->caps |= UFSHCD_CAP_MCQ_EN;
>
>Shouldn't we have a flag that disables MCQ rather than a flag that
>enables MCQ? Otherwise the above line will be duplicated in every
>single host controller driver that supports MCQ.
>
Thanks, that makes sense.
I will drop this change and add a cap to disable MCQ via module parameter.
>Thanks,
>
>Bart.
-asd
next prev parent reply other threads:[~2022-11-01 18:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 18:03 [PATCH v3 00/17] Add Multi Circular Queue Support Asutosh Das
2022-10-20 18:03 ` [PATCH v3 01/17] ufs: core: Probe for ext_iid support Asutosh Das
2022-10-27 21:02 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 02/17] ufs: core: Optimize duplicate code to read extended feature Asutosh Das
2022-10-27 21:05 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 03/17] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-10-27 21:09 ` Bart Van Assche
2022-10-28 16:51 ` Asutosh Das
2022-10-28 21:44 ` Bart Van Assche
2022-10-30 12:11 ` Avri Altman
2022-10-20 18:03 ` [PATCH v3 04/17] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-10-27 21:18 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 05/17] ufs: core: mcq: Introduce Multi Circular Queue Asutosh Das
2022-10-27 21:33 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 06/17] ufs: core: mcq: Configure resource regions Asutosh Das
2022-10-26 9:14 ` Eddie Huang
2022-10-20 18:03 ` [PATCH v3 07/17] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-10-27 21:52 ` Bart Van Assche
2022-10-30 11:43 ` Avri Altman
2022-10-31 19:34 ` Asutosh Das
2022-10-31 19:24 ` Asutosh Das
2022-10-31 19:42 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 08/17] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-10-27 21:38 ` Bart Van Assche
2022-10-30 12:28 ` Avri Altman
2022-10-31 19:39 ` Asutosh Das
2022-10-20 18:03 ` [PATCH v3 09/17] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-10-27 22:01 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 10/17] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-10-28 21:47 ` Bart Van Assche
2022-10-30 13:06 ` Avri Altman
2022-11-01 16:29 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 11/17] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-10-28 21:49 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 12/17] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-10-28 21:53 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 13/17] ufs: core: Prepare for completion in mcq Asutosh Das
2022-10-28 21:56 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 14/17] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-10-28 22:05 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 15/17] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-10-28 22:07 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 16/17] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das
2022-10-28 22:07 ` Bart Van Assche
2022-10-20 18:03 ` [PATCH v3 17/17] ufs: qcom-host: Enable multi circular queue capability Asutosh Das
2022-10-28 22:08 ` Bart Van Assche
2022-11-01 18:47 ` Asutosh Das [this message]
2022-10-26 9:21 ` [PATCH v3 00/17] Add Multi Circular Queue Support Eddie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221101184718.GG9077@asutoshd-linux1.qualcomm.com \
--to=quic_asutoshd@quicinc.com \
--cc=agross@kernel.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bjorn.andersson@linaro.org \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_richardp@quicinc.com \
--cc=quic_xiaosenh@quicinc.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.