From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
rafael@kernel.org, robh+dt@kernel.org, johan@kernel.org,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 7/7] cpufreq: qcom-hw: Add CPU clock provider support
Date: Wed, 2 Nov 2022 12:24:48 +0530 [thread overview]
Message-ID: <20221102065448.GA10650@thinkpad> (raw)
In-Reply-To: <20221102042849.q3qnaoebeudpbpnv@vireshk-i7>
On Wed, Nov 02, 2022 at 09:58:49AM +0530, Viresh Kumar wrote:
> On 25-10-22, 13:02, Manivannan Sadhasivam wrote:
> > for (i = 0; i < num_domains; i++) {
> > struct qcom_cpufreq_data *data = &qcom_cpufreq.data[i];
> > + static struct clk_init_data init = {};
>
> Why not make this part of a driver level structure instead of static ?
> And what will {} do ? Initialize to 0 ? static would have already done
> that.
>
Good catch! "static" is not needed here.
Thanks,
Mani
> --
> viresh
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2022-11-02 6:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:32 [PATCH v2 0/7] qcom-cpufreq-hw: Add CPU clock provider support Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 1/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Add cpufreq clock provider Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 2/7] arm64: dts: qcom: sm8450: Supply clock from cpufreq node to CPUs Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 3/7] cpufreq: qcom-hw: Remove un-necessary cpumask_empty() check Manivannan Sadhasivam
2022-11-02 6:50 ` Viresh Kumar
2022-10-25 7:32 ` [PATCH v2 4/7] cpufreq: qcom-hw: Allocate qcom_cpufreq_data during probe Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 5/7] cpufreq: qcom-hw: Use cached dev pointer in probe() Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 6/7] cpufreq: qcom-hw: Move soc_data to struct qcom_cpufreq Manivannan Sadhasivam
2022-10-25 7:32 ` [PATCH v2 7/7] cpufreq: qcom-hw: Add CPU clock provider support Manivannan Sadhasivam
2022-11-02 4:28 ` Viresh Kumar
2022-11-02 6:54 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102065448.GA10650@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.