From: Rob Herring <robh@kernel.org>
To: cy_huang <u0084500@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org,
lgirdwood@gmail.com, cy_huang@richtek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: regulator: Add bindings for Richtek RT6190 regulator
Date: Wed, 2 Nov 2022 09:07:01 -0500 [thread overview]
Message-ID: <20221102140701.GA3704610-robh@kernel.org> (raw)
In-Reply-To: <1667183334-16511-2-git-send-email-u0084500@gmail.com>
On Mon, Oct 31, 2022 at 10:28:53AM +0800, cy_huang wrote:
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add devicetree binding for Richtek RT6190 4-Switch buckboost controller.
>
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> ---
> Hi, Rob:
>
> Since I didn't got any reply from the v2 dt-binding question.
> https://lore.kernel.org/lkml/CADiBU3_WUeyYdnmnG0Ff2pH+b3u1zOtP1z44LcA53Ba5c9nrEw@mail.gmail.com/
> In v3, I aleady fixed it following by your comment.
>
> I'm just wondering the corrent usage.
> As I know, 'enable-gpios' comes from 'gpio-consumer-common.yaml'.
> In the common yaml file, it's already declared 'enable-gpios' maxItems as '1'.
> That's why I just declared it as 'true'.
Yes, you are right. Either way is fine then.
> Since v3:
> - Fix the typo 'upply' to 'supply'.
> - Declare 'enable-gpios' maxItems as 1.
> - Declare the 'maxItems' for the property 'regulator-allowed-modes'.
>
> Since v2:
> - Rename binding filename to 'richtek,rt6190.yaml'
>
> ---
> .../bindings/regulator/richtek,rt6190.yaml | 79 ++++++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/richtek,rt6190.yaml
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-11-02 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 2:28 [PATCH v3 0/2] Add support for Richtek RT6190 36V 4-wwtich regulator cy_huang
2022-10-31 2:28 ` [PATCH v3 1/2] dt-bindings: regulator: Add bindings for Richtek RT6190 regulator cy_huang
2022-11-02 14:07 ` Rob Herring [this message]
2022-10-31 2:28 ` [PATCH v3 2/2] regulator: rt6190: Add support " cy_huang
2022-11-02 16:25 ` [PATCH v3 0/2] Add support for Richtek RT6190 36V 4-wwtich regulator Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221102140701.GA3704610-robh@kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.