Re: [Buildroot] [PATCH 1/2] package/busybox: add patch to silence build errors

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Vincent Fazio <vfazio@xes-inc.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/busybox: add patch to silence build errors
Date: Wed, 2 Nov 2022 23:00:54 +0100	[thread overview]
Message-ID: <20221102220054.GC3918838@scaer> (raw)
In-Reply-To: <20221101234024.27b5bc48@windsurf>

Thomas, All,

On 2022-11-01 23:40 +0100, Thomas Petazzoni via buildroot spake thusly:
> On Fri,  7 Oct 2022 18:50:01 -0500
> Vincent Fazio <vfazio@xes-inc.com> wrote:
> 
> > As part of pkg-kconfig, the .config file gets regenerated after fixups.
> > 
> > When Busybox is built with per-package directories enabled, the
> > toolchain is not available for Busybox's makefile to determine compiler
> > capabilities so certain calls will fail and emit errors.
> > 
> > For now, assume the following are true:
> > 
> > Buildroot will not use GCC < 4
> >   Skip a call to cc-ifversion to avoid the following error
> > 
> >   /buildroot/output/build/busybox-1.35.0/scripts/gcc-version.sh: line 11: /buildroot/output/per-package/busybox/host/bin/x86_64-linux-gcc: No such file or directory
> > 
> > Target system is linux
> >   Skip a call to -dumpmachine to avoid the following error
> > 
> >   make[2]: /buildroot/output/per-package/busybox/host/bin/x86_64-linux-gcc: Command not found
> > 
> > Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
> 
> Hm, it's a bit annoying to patch Busybox for this, especially with a
> patch that most likely cannot be accepted upstream because it's really
> related to Buildroot details.
> 
> Do we have a better solution?

Yes: we should be relatively confident that we can convince busybox that
they wil never be built against a gcc < 4 nowadays, no?

scripts/gcc-version.sh is used to get the gcc version. This is in turn
used to test whether gcc >= 4.00, in which case -Wold-style-definition
is added to CFLAGS.

That is is only one case where this is needed. gcc 4.0.0 was release in
2005-04-20, 17+ years ago now. This is probably the oldest gcc version
one may reasnably expect to compile current code aganst. nowadays...

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot