From: Christoph Hellwig <hch@lst.de>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: hch@lst.de, axboe@kernel.dk, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH 1/2] block: don't allow a disk link holder to itself
Date: Thu, 3 Nov 2022 09:06:28 +0100 [thread overview]
Message-ID: <20221103080628.GA3346@lst.de> (raw)
In-Reply-To: <20221103025541.1875809-2-yukuai1@huaweicloud.com>
Yes, this is a good one. Please add a single sentence blurb explaing
the issue before the Test prodecure?
With that this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Thu, Nov 03, 2022 at 10:55:40AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Test procedures:
>
> 1) dmsetup create test --table "xxx sda", assume dm-0 is created
> 2) dmsetup suspend test
> 3) dmsetup reload test --table "xxx dm-0"
> 4) dmsetup resume test
Can you wire this up for blocktests?
I've also been wondering how we could wire your other two test cases
up as I think they'be very useful. Hopefully I can find some time
to inject delays with eBPF or something like it.
next prev parent reply other threads:[~2022-11-03 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 2:55 [PATCH 0/2] block: bugfix for bd_link_disk_holder() Yu Kuai
2022-11-03 2:55 ` [PATCH 1/2] block: don't allow a disk link holder to itself Yu Kuai
2022-11-03 8:06 ` Christoph Hellwig [this message]
2022-11-03 9:17 ` Yu Kuai
2022-11-03 2:55 ` [PATCH 2/2] block: fix use after free for bd_holder_dir Yu Kuai
2022-11-03 8:12 ` Christoph Hellwig
2022-11-03 9:45 ` Yu Kuai
2022-11-03 9:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103080628.GA3346@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.