From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E554C433FE for ; Thu, 3 Nov 2022 12:40:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229993AbiKCMkl (ORCPT ); Thu, 3 Nov 2022 08:40:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiKCMkk (ORCPT ); Thu, 3 Nov 2022 08:40:40 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14C210BE; Thu, 3 Nov 2022 05:40:35 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F40E868AA6; Thu, 3 Nov 2022 13:40:30 +0100 (CET) Date: Thu, 3 Nov 2022 13:40:30 +0100 From: Christoph Hellwig To: Thorsten Leemhuis Cc: Christoph Hellwig , Jens Axboe , Matthew Wilcox , Johannes Weiner , Suren Baghdasaryan , Andrew Morton , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org, "regressions@lists.linux.dev" Subject: Re: [REGESSION] systemd-oomd overreacting due to PSI changes for Btrfs (was: Re: [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads) Message-ID: <20221103124030.GA29839@lst.de> References: <20220915094200.139713-1-hch@lst.de> <20220915094200.139713-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Nov 03, 2022 at 11:46:52AM +0100, Thorsten Leemhuis wrote: > It seems this patch makes systemd-oomd overreact on my day-to-day > machine and aggressively kill applications. I'm not the only one that > noticed such a behavior with 6.1 pre-releases: > https://bugzilla.redhat.com/show_bug.cgi?id=2133829 > https://bugzilla.redhat.com/show_bug.cgi?id=2134971 > > I think I have a pretty reliable way to trigger the issue that involves > starting the apps that I normally use and a VM that I occasionally use, > which up to now never resulted in such a behaviour. > > On master as of today (8e5423e991e8) I can trigger the problem within a > minute or two. But I fail to trigger it with v6.0.6 or when I revert > 4088a47e78f9 ("btrfs: add manual PSI accounting for compressed reads"). > And yes, I use btrfs with compression for / and /home/. So, I did in fact not want to include this patch because it is a little iffy and includes PSI accounting for reads where btrfs just does aggresive readaround for compression, but Johannes asked for it to be added. I'd be perfectly fine with just reverting it. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B37D1C4332F for ; Thu, 3 Nov 2022 12:47:37 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4N33SS229Kz3ccq for ; Thu, 3 Nov 2022 23:47:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lst.de (client-ip=213.95.11.211; helo=verein.lst.de; envelope-from=hch@lst.de; receiver=) X-Greylist: delayed 384 seconds by postgrey-1.36 at boromir; Thu, 03 Nov 2022 23:47:03 AEDT Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4N33Rq2dzjz3cKr for ; Thu, 3 Nov 2022 23:47:03 +1100 (AEDT) Received: by verein.lst.de (Postfix, from userid 2407) id F40E868AA6; Thu, 3 Nov 2022 13:40:30 +0100 (CET) Date: Thu, 3 Nov 2022 13:40:30 +0100 From: Christoph Hellwig To: Thorsten Leemhuis Subject: Re: [REGESSION] systemd-oomd overreacting due to PSI changes for Btrfs (was: Re: [PATCH 3/5] btrfs: add manual PSI accounting for compressed reads) Message-ID: <20221103124030.GA29839@lst.de> References: <20220915094200.139713-1-hch@lst.de> <20220915094200.139713-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , "regressions@lists.linux.dev" , linux-mm@kvack.org, linux-erofs@lists.ozlabs.org, Josef Bacik , Matthew Wilcox , linux-block@vger.kernel.org, Chris Mason , Johannes Weiner , David Sterba , linux-fsdevel@vger.kernel.org, Andrew Morton , Suren Baghdasaryan , Christoph Hellwig , linux-btrfs@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Thu, Nov 03, 2022 at 11:46:52AM +0100, Thorsten Leemhuis wrote: > It seems this patch makes systemd-oomd overreact on my day-to-day > machine and aggressively kill applications. I'm not the only one that > noticed such a behavior with 6.1 pre-releases: > https://bugzilla.redhat.com/show_bug.cgi?id=2133829 > https://bugzilla.redhat.com/show_bug.cgi?id=2134971 > > I think I have a pretty reliable way to trigger the issue that involves > starting the apps that I normally use and a VM that I occasionally use, > which up to now never resulted in such a behaviour. > > On master as of today (8e5423e991e8) I can trigger the problem within a > minute or two. But I fail to trigger it with v6.0.6 or when I revert > 4088a47e78f9 ("btrfs: add manual PSI accounting for compressed reads"). > And yes, I use btrfs with compression for / and /home/. So, I did in fact not want to include this patch because it is a little iffy and includes PSI accounting for reads where btrfs just does aggresive readaround for compression, but Johannes asked for it to be added. I'd be perfectly fine with just reverting it.