From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Ren <andy.ren@getcruise.com>
Cc: netdev@vger.kernel.org, richardbgobert@gmail.com,
davem@davemloft.net, wsa+renesas@sang-engineering.com,
edumazet@google.com, petrm@nvidia.com, kuba@kernel.org,
pabeni@redhat.com, corbet@lwn.net, andrew@lunn.ch,
dsahern@gmail.com, sthemmin@microsoft.com, idosch@idosch.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
roman.gushchin@linux.dev
Subject: Re: [PATCH net-next] net/core: Allow live renaming when an interface is up
Date: Thu, 3 Nov 2022 19:19:58 -0700 [thread overview]
Message-ID: <20221103191958.2b9aa91e@hermes.local> (raw)
In-Reply-To: <20221103235847.3919772-1-andy.ren@getcruise.com>
On Thu, 3 Nov 2022 16:58:47 -0700
Andy Ren <andy.ren@getcruise.com> wrote:
> @@ -1691,7 +1690,6 @@ enum netdev_priv_flags {
> IFF_FAILOVER = 1<<27,
> IFF_FAILOVER_SLAVE = 1<<28,
> IFF_L3MDEV_RX_HANDLER = 1<<29,
> - IFF_LIVE_RENAME_OK = 1<<30,
> IFF_TX_SKB_NO_LINEAR = BIT_ULL(31),
> IFF_CHANGE_PROTO_DOWN = BIT_ULL(32),
> };
It helps with developers memory if you change the line to something like:
/* was IFF_RENAME_OK */
next prev parent reply other threads:[~2022-11-04 2:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 23:58 [PATCH net-next] net/core: Allow live renaming when an interface is up Andy Ren
2022-11-04 1:56 ` Bagas Sanjaya
2022-11-04 2:19 ` Stephen Hemminger [this message]
2022-11-04 2:50 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2022-11-03 22:46 Andy Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221103191958.2b9aa91e@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew@lunn.ch \
--cc=andy.ren@getcruise.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=richardbgobert@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=sthemmin@microsoft.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.