All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>,
	Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-opcua-asyncio: bump to version 1.0.0
Date: Thu, 3 Nov 2022 21:58:12 +0100	[thread overview]
Message-ID: <20221103215812.58a4ca20@windsurf> (raw)
In-Reply-To: <20221103132829.1589487-1-james.hilliard1@gmail.com>

Hello James,

On Thu,  3 Nov 2022 07:28:29 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/python-opcua-asyncio/python-opcua-asyncio.hash | 6 ++++--
>  package/python-opcua-asyncio/python-opcua-asyncio.mk   | 6 +++---
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/package/python-opcua-asyncio/python-opcua-asyncio.hash b/package/python-opcua-asyncio/python-opcua-asyncio.hash
> index d8aee272de..36b16a1596 100644
> --- a/package/python-opcua-asyncio/python-opcua-asyncio.hash
> +++ b/package/python-opcua-asyncio/python-opcua-asyncio.hash
> @@ -1,3 +1,5 @@
> -# Locally computed
> -sha256  e5fab37a92162351fe40cab43df09db8a2e9f8b8a2a8f13ed680aa6f6d687ec3  opcua-asyncio-0.8.4.tar.gz
> +# md5, sha256 from https://pypi.org/pypi/asyncua/json
> +md5  a52df0dc0586abd1592c97a0274d1c9d  asyncua-1.0.0.tar.gz
> +sha256  25966e374b0c90da112a96e9dbc5cc36c123b2b60412eac6f26b04a4b0b4d91e  asyncua-1.0.0.tar.gz

Are you sure this is the same thing: opcua-asyncio-0.8.4.tar.gz and
asyncua-1.0.0.tar.gz ?

> +# Locally computed sha256 checksums
>  sha256  da7eabb7bafdf7d3ae5e9f223aa5bdc1eece45ac569dc21b3b037520b4464768  COPYING
> diff --git a/package/python-opcua-asyncio/python-opcua-asyncio.mk b/package/python-opcua-asyncio/python-opcua-asyncio.mk
> index 50b581037b..54f8a1d0a0 100644
> --- a/package/python-opcua-asyncio/python-opcua-asyncio.mk
> +++ b/package/python-opcua-asyncio/python-opcua-asyncio.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -PYTHON_OPCUA_ASYNCIO_VERSION = 0.8.4
> -PYTHON_OPCUA_ASYNCIO_SOURCE = opcua-asyncio-$(PYTHON_OPCUA_ASYNCIO_VERSION).tar.gz
> -PYTHON_OPCUA_ASYNCIO_SITE = $(call github,FreeOpcUa,opcua-asyncio,$(PYTHON_OPCUA_ASYNCIO_VERSION))
> +PYTHON_OPCUA_ASYNCIO_VERSION = 1.0.0
> +PYTHON_OPCUA_ASYNCIO_SOURCE = asyncua-$(PYTHON_ASYNCUA_VERSION).tar.gz

I don't see how this can work: this package defines
PYTHON_OPCUA_ASYNCIO_VERSION, but you use PYTHON_ASYNCUA_VERSION. Did
you test this? :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-11-03 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-03 13:28 [Buildroot] [PATCH 1/1] package/python-opcua-asyncio: bump to version 1.0.0 James Hilliard
2022-11-03 20:58 ` Thomas Petazzoni via buildroot [this message]
2022-11-03 21:38   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221103215812.58a4ca20@windsurf \
    --to=buildroot@buildroot.org \
    --cc=asafka7@gmail.com \
    --cc=james.hilliard1@gmail.com \
    --cc=jugurtha.belkalem@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.