From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CEA8C433FE for ; Fri, 4 Nov 2022 07:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667547164; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=YZCH+UsD+md2GCYdW4LzRvP87LcKOVorAZhHRXvqKRM=; b=ZGDvFd+RulsDbb5x7ACEWV5tun/QseITiHP/+QWT6OQdjBCiqsSx+V9yj8MkimKMGtuRDN wHAZoahYbrgtziUHd6NM7sj6j/pj3JZC7zFx4bKZlpxOD24Xd9mDQXcMsS8y6XKIVVPfca TD8bFl6dCqY/lmpwn7qyMDT8kcd7b7Y= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-42-mgwt8qTAPe2R7DPDiQQUrg-1; Fri, 04 Nov 2022 03:32:43 -0400 X-MC-Unique: mgwt8qTAPe2R7DPDiQQUrg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3CB9299E76E; Fri, 4 Nov 2022 07:32:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EFE1D18EB4; Fri, 4 Nov 2022 07:32:29 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 98DF21946597; Fri, 4 Nov 2022 07:32:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 2BFDB1946594 for ; Fri, 4 Nov 2022 07:32:27 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 04952205FA8A; Fri, 4 Nov 2022 07:32:26 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F1C5A205FA86 for ; Fri, 4 Nov 2022 07:32:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3492329AB3F4 for ; Fri, 4 Nov 2022 07:32:24 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-329-XRgMQaIPNGKO6U-wU5q-fg-1; Fri, 04 Nov 2022 03:32:20 -0400 X-MC-Unique: XRgMQaIPNGKO6U-wU5q-fg-1 Received: by verein.lst.de (Postfix, from userid 2407) id 64F2968B05; Fri, 4 Nov 2022 08:32:16 +0100 (CET) Date: Fri, 4 Nov 2022 08:32:16 +0100 From: Christoph Hellwig To: Eric Biggers Message-ID: <20221104073216.GA18231@lst.de> References: <20221104054621.628369-1-hch@lst.de> <20221104054621.628369-2-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Subject: Re: [dm-devel] [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , "Theodore Y. Ts'o" , Mike Snitzer , linux-fscrypt@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Jaegeuk Kim , Christoph Hellwig Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Nov 04, 2022 at 12:28:13AM -0700, Eric Biggers wrote: > Shouldn't the three places above still say request_queue, not block_device? > They're talking about the driver. Yes, probably. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA62EC43217 for ; Fri, 4 Nov 2022 07:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbiKDHc2 (ORCPT ); Fri, 4 Nov 2022 03:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231518AbiKDHcY (ORCPT ); Fri, 4 Nov 2022 03:32:24 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9001CB19; Fri, 4 Nov 2022 00:32:20 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 64F2968B05; Fri, 4 Nov 2022 08:32:16 +0100 (CET) Date: Fri, 4 Nov 2022 08:32:16 +0100 From: Christoph Hellwig To: Eric Biggers Cc: Christoph Hellwig , Jens Axboe , Mike Snitzer , "Theodore Y. Ts'o" , Jaegeuk Kim , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org Subject: Re: [PATCH 1/2] blk-crypto: don't use struct request_queue for public interfaces Message-ID: <20221104073216.GA18231@lst.de> References: <20221104054621.628369-1-hch@lst.de> <20221104054621.628369-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Nov 04, 2022 at 12:28:13AM -0700, Eric Biggers wrote: > Shouldn't the three places above still say request_queue, not block_device? > They're talking about the driver. Yes, probably.